Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-6241): allow Binary as local KMS provider key #4160

Merged
merged 2 commits into from
Jun 26, 2024
Merged

fix(NODE-6241): allow Binary as local KMS provider key #4160

merged 2 commits into from
Jun 26, 2024

Conversation

addaleax
Copy link
Contributor

@addaleax addaleax commented Jun 25, 2024 •
edited by nbbeeken
Loading

This aligns the types with actual behavior as well as the shell's expected set of supported types.

Description

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Accurate TS

Release Highlight

The LocalKMSProviderConfiguration's key property accepts Binary

A local KMS provider at runtime accepted a BSON Binary instance but the Typescript inaccurately only permitted Buffer and string.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@addaleax
fix(NODE-6241): allow Binary as local KMS provider key
56b7ab1 
This aligns the types with actual behavior as well as the shell's
expected set of supported types.
@nbbeeken nbbeeken self-assigned this Jun 25, 2024
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 25, 2024
@addaleax @nbbeeken
Update src/client-side-encryption/providers/index.ts
9043877 
Co-authored-by: Neal Beeken <neal.beeken@mongodb.com>
@addaleax addaleax requested a review from nbbeeken June 25, 2024 22:16
@nbbeeken nbbeeken merged commit fb724eb into mongodb:main Jun 26, 2024
27 of 29 checks passed
@github-actions github-actions bot mentioned this pull request Jun 26, 2024
Merged
@nbbeeken nbbeeken mentioned this pull request Jun 28, 2024
Merged
5 tasks
@github-actions github-actions bot mentioned this pull request Jul 2, 2024
Merged
@snyk-io snyk-io bot mentioned this pull request Jul 18, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Jul 19, 2024
Open
@prernaadev01 prernaadev01 mentioned this pull request Jul 19, 2024
Closed
@issam-seghir issam-seghir mentioned this pull request Jul 19, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Jul 19, 2024
Open
@lryanle lryanle mentioned this pull request Jul 19, 2024
Open
@kazimanzurrashid kazimanzurrashid mentioned this pull request Jul 19, 2024
Closed
@MohammadGhajari MohammadGhajari mentioned this pull request Jul 19, 2024
Open
@lydmoon lydmoon mentioned this pull request Jul 19, 2024
Open
@mkusztal mkusztal mentioned this pull request Jul 19, 2024
Open
@brutussegun brutussegun mentioned this pull request Jul 19, 2024
Open
@akashkumar8115 akashkumar8115 mentioned this pull request Jul 20, 2024
Open
@tarun2001jawla tarun2001jawla mentioned this pull request Jul 20, 2024
Open
@aliakseikrauchanka aliakseikrauchanka mentioned this pull request Jul 20, 2024
Merged
@Pxntricia Pxntricia mentioned this pull request Jul 25, 2024
Open
@bakiUru bakiUru mentioned this pull request Jul 31, 2024
Open
@asifurrahmanpial asifurrahmanpial mentioned this pull request Aug 2, 2024
Open
This was referenced Aug 2, 2024
Merged
Merged
@visrut-at-incubyte visrut-at-incubyte mentioned this pull request Oct 4, 2024
Open
@IzzyDotExe IzzyDotExe mentioned this pull request Oct 4, 2024
Merged
This was referenced Oct 5, 2024
Merged
Merged
Merged
@arenault-pass arenault-pass mentioned this pull request Oct 5, 2024
Closed
@MoaidHashem3 MoaidHashem3 mentioned this pull request Oct 5, 2024
Open
@mkusztal mkusztal mentioned this pull request Oct 5, 2024
Open
@WontonSam WontonSam mentioned this pull request Oct 5, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Oct 6, 2024
Closed
@Abhishekh669 Abhishekh669 mentioned this pull request Oct 25, 2024
Open
@aliakseikrauchanka aliakseikrauchanka mentioned this pull request Oct 25, 2024
Open
@parseplatformorg parseplatformorg mentioned this pull request Oct 26, 2024
Closed
@Xcaciv Xcaciv mentioned this pull request Oct 26, 2024
Open
@MohammadGhajari MohammadGhajari mentioned this pull request Oct 28, 2024
Open
@lydmoon lydmoon mentioned this pull request Oct 28, 2024
Open
@xeni09 xeni09 mentioned this pull request Oct 28, 2024
Merged
@abaum65 abaum65 mentioned this pull request Oct 29, 2024
Open
@mentorscx mentorscx mentioned this pull request Nov 7, 2024
Open
@prosenjit07 prosenjit07 mentioned this pull request Nov 8, 2024
Open
@parseplatformorg parseplatformorg mentioned this pull request Nov 9, 2024
Closed
@WontonSam WontonSam mentioned this pull request Nov 11, 2024
Open
@shafeeqd959 shafeeqd959 mentioned this pull request Nov 11, 2024
Open
@TartejBrothers TartejBrothers mentioned this pull request Nov 12, 2024
Merged
@akanchhaS akanchhaS mentioned this pull request Nov 12, 2024
Open
@zntb zntb mentioned this pull request Nov 12, 2024
Closed
@skanda890 skanda890 mentioned this pull request Nov 12, 2024
Merged
@thnbih thnbih mentioned this pull request Nov 12, 2024
Open
This was referenced Nov 13, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees

@nbbeeken nbbeeken

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addaleax @nbbeeken