Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-6305): Add CSOT support to tailable cursors #4218

Merged
merged 141 commits into from
Oct 7, 2024
Merged

feat(NODE-6305): Add CSOT support to tailable cursors #4218

merged 141 commits into from
Oct 7, 2024

Conversation

W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Sep 3, 2024 •
edited
Loading

Description

What is changing?

AbstractCursor
  • Added logic to implement CSOT logic for tailable awaitData and non-awaitData cursors
onData
  • Only relevant change here is the addition of the commented code used for debugging purposes. Other diffs in this area are due to a messy rebase, but have been checked and are consistent with the expected state of this code. note that all previous CSOT spec, prose and unit tests continue to pass.
RunCommandCursor
  • Added support for tailable and awaitData flags
MongoClient
  • added internal timeoutMS getter
Benchmarks
  • Duplicated all existing benchmarks except the return document benchmark with csot enabled (with an infinite timeout)
Testing
  • Unskipped (and fixed) tailable cursor Blocking Iteration method test
  • Unskipped tailable awaitData and non-awaitData spec tests, duplicated and modified some tests which are only failing due to the the emission of a killCursors event when cleaning up the test resources. Original tests that were skipped have accompanying TODO with linked ticket
  • Added int tests for tailable awaitData and non-awaitData cursors
  • Updated UTR to interpret cursorType
  • Updated UTR to pass through correct options for RunCommandCursor
Is there new documentation needed for these changes?

Not for this PR

What is the motivation for this change?

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

W-A-James and others added 30 commits August 21, 2024 13:02
@W-A-James @nbbeeken
feat(NODE-6090): Implement CSOT logic for connection checkout and ser…
d513fd6 
…ver selection
@W-A-James @nbbeeken
test(NODE-6120): Implement Unified test runner changes for CSOT (#4121)
7d65aae
@W-A-James @nbbeeken
refactor(NODE-6187): refactor to use TimeoutContext abstraction (#4131)
954e713
@nbbeeken
refactor(NODE-6230): executeOperation to use iterative retry mechanism (
c5969b2 
#4157)
@nbbeeken @W-A-James
feat(NODE-5682): set maxTimeMS on commands and preempt I/O (#4174)
8599cb3 
Co-authored-by: Warren James <warren.james@mongodb.com>
@W-A-James @nbbeeken
feat(NODE-6231): Add CSOT behaviour for retryable reads and writes (#…
7b9fa1f 
…4186)
@nbbeeken
feat(NODE-6312): add error transformation for server timeouts (#4192)
260d679
@W-A-James
add timeoutMode to find, findOne, listIndexes, aggregate, listCollect…
78eb356 
…ions
@W-A-James
unskip spec tests
a22784d
@W-A-James
implement prose tests
6c423e0
@W-A-James
Add timeoutMode to abstract cursor and add validation
978d8dd
@W-A-James
Add $out and $merge validation
5317378
@W-A-James
start csot cursor implementation
7c459e0
@W-A-James
WIP: int testing
0a2e4ce
@W-A-James
WIP
ac97b5a
@W-A-James
fix test
02f835e
@W-A-James
correctly propagate timeoutMode
1e65e25
@W-A-James
rework test skip logic
0bc7793
@W-A-James
wip
f83d3ef
@W-A-James
prose tests WIP
9549fd4
@W-A-James
put CSOT options on runCursorCommand
173796b
@W-A-James
finish up int tests
9fc4c4e
@W-A-James
timeoutContext refresh fix
507af55
@W-A-James
apply CSOT to hasNext and tryNext
1f27040
@W-A-James
sync spec tests
af02eb8
@W-A-James
add omitMaxTimeMS
679c02c
@W-A-James
skipping spec tests
abc1cfd
@W-A-James
pass through timeoutMS arg to cursor.close
b64af7b
@W-A-James
Fix tests and dropindexes
628eb55
@W-A-James
add catch
e90e7ed
baileympearson
baileympearson requested changes Sep 26, 2024
View reviewed changes
src/cmap/wire_protocol/on_data.ts Outdated Show resolved Hide resolved
src/cursor/abstract_cursor.ts Outdated Show resolved Hide resolved
src/cursor/abstract_cursor.ts Outdated Show resolved Hide resolved
src/cursor/abstract_cursor.ts Outdated Show resolved Hide resolved
test/integration/client-side-operations-timeout/node_csot.test.ts Show resolved Hide resolved
test/integration/client-side-operations-timeout/node_csot.test.ts Show resolved Hide resolved
test/integration/client-side-operations-timeout/node_csot.test.ts Show resolved Hide resolved
@baileympearson baileympearson added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Oct 7, 2024
@baileympearson baileympearson merged commit 9a1b2d0 into NODE-6090 Oct 7, 2024
22 of 24 checks passed
@baileympearson baileympearson deleted the NODE-6305 branch October 7, 2024 17:07
baileympearson pushed a commit that referenced this pull request Oct 10, 2024
@W-A-James @nbbeeken @baileympearson
feat(NODE-6305): Add CSOT support to tailable cursors (#4218)
27fc6a9 
Co-authored-by: Neal Beeken <neal.beeken@mongodb.com>
baileympearson pushed a commit that referenced this pull request Oct 10, 2024
@W-A-James @nbbeeken @baileympearson
feat(NODE-6305): Add CSOT support to tailable cursors (#4218)
af6a4e2 
Co-authored-by: Neal Beeken <neal.beeken@mongodb.com>
nbbeeken added a commit that referenced this pull request Oct 14, 2024
@W-A-James @nbbeeken
feat(NODE-6305): Add CSOT support to tailable cursors (#4218)
4488bab 
Co-authored-by: Neal Beeken <neal.beeken@mongodb.com>
baileympearson pushed a commit that referenced this pull request Oct 21, 2024
@W-A-James @nbbeeken @baileympearson
feat(NODE-6305): Add CSOT support to tailable cursors (#4218)
638b9ce 
Co-authored-by: Neal Beeken <neal.beeken@mongodb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileympearson baileympearson baileympearson approved these changes

Assignees

@baileympearson baileympearson

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@W-A-James @baileympearson @nbbeeken