feat(NODE-5844): add iscryptd to ServerDescription #4239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
force-pushed
the
NODE-5844-iscryptd
branch
from
55a7d55 to
fe3c54b
Compare
nbbeeken
force-pushed
the
NODE-5844-iscryptd
branch
from
fe3c54b to
bc6a4c9
Compare
W-A-James
added
the
Primary Review
W-A-James
approved these changes
Sep 16, 2024
W-A-James
added
Team Review
baileympearson
requested changes
Sep 16, 2024
test/integration/server-discovery-and-monitoring/server_description.test.ts
Show resolved
Hide resolved
test/integration/server-discovery-and-monitoring/server_description.test.ts
Show resolved
Hide resolved
test/integration/server-discovery-and-monitoring/server_description.test.ts
Outdated
Show resolved
Hide resolved
baileympearson
approved these changes
Sep 16, 2024
nbbeeken
added a commit
that referenced
this pull request
Sep 25, 2024
nbbeeken
added a commit
that referenced
this pull request
Sep 27, 2024
baileympearson
pushed a commit
that referenced
this pull request
Oct 1, 2024
baileympearson
pushed a commit
that referenced
this pull request
Oct 1, 2024
baileympearson
pushed a commit
that referenced
this pull request
Oct 10, 2024
nbbeeken
added a commit
that referenced
this pull request
Oct 14, 2024
baileympearson
pushed a commit
that referenced
this pull request
Oct 21, 2024
nbbeeken
added a commit
that referenced
this pull request
Nov 1, 2024
nbbeeken
added a commit
that referenced
this pull request
Nov 5, 2024
dariakp
pushed a commit
that referenced
this pull request
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Add iscryptd to serverDescription
Is there new documentation needed for these changes?
No
What is the motivation for this change?
Need to be able to identify mongocryptd instances
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript