Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NODE-6843): send results to perf endpoint #4455

Merged
merged 4 commits into from
Mar 12, 2025
Merged

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

So tags are used

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken
Copy link
Contributor Author

nbbeeken commented Mar 11, 2025

@nbbeeken nbbeeken force-pushed the NODE-6843-perf-endpoint branch from f4ab53c to 1a1ff6d Compare March 11, 2025 22:59
@nbbeeken nbbeeken marked this pull request as ready for review March 12, 2025 01:09
@nbbeeken nbbeeken requested a review from a team as a code owner March 12, 2025 01:09
@dariakp
Copy link
Contributor

dariakp commented Mar 12, 2025

@nbbeeken added the perf CI tasks, to see what this looks like - do we expect any difference in the response of the endpoint between this PR and main?

@nbbeeken
Copy link
Contributor Author

@dariakp The patch I linked has already run with the latest commit here. No difference, this is the same change made to BSON and we confirmed the data is inserted into the backing db

@nbbeeken nbbeeken requested a review from dariakp March 12, 2025 18:54
@dariakp dariakp self-assigned this Mar 12, 2025
@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Mar 12, 2025
@dariakp dariakp merged commit 54d29e5 into main Mar 12, 2025
27 of 31 checks passed
@dariakp dariakp deleted the NODE-6843-perf-endpoint branch March 12, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants