Skip to content

test(NODE-7199): Migrate test/integration/crud/misc_cursor tests #4741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 23, 2025
Merged

test(NODE-7199): Migrate test/integration/crud/misc_cursor tests #4741

merged 7 commits into from
Oct 23, 2025
+1,946 −4,102

Conversation

@PavelSafronov
Copy link
Contributor

@PavelSafronov PavelSafronov commented Oct 17, 2025

Description

Summary of Changes

Migrating test/integration/crud/misc_cursor driver callback API style tests to promises.

What is the motivation for this change?

https://jira.mongodb.org/browse/NODE-4979

We want to modify all tests to no longer use callbacks as the driver is a promise only API now. This is a requirement for deprecating the legacy driver.

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@PavelSafronov PavelSafronov marked this pull request as ready for review October 21, 2025 17:15
@PavelSafronov PavelSafronov requested a review from a team as a code owner October 21, 2025 17:15
@baileympearson baileympearson self-assigned this Oct 21, 2025
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Oct 21, 2025
baileympearson
baileympearson requested changes Oct 21, 2025
View reviewed changes
baileympearson
baileympearson requested changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one remaining comment. Looks good! Thanks for addressing my other comments so quickly.

@baileympearson baileympearson merged commit 51c1b9d into mongodb:main Oct 23, 2025
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baileympearson baileympearson baileympearson approved these changes

Assignees

@baileympearson baileympearson

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PavelSafronov @baileympearson