CLOUDP-286235: Improved tooling (ESLint/Prettier) and GH actions #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gssbzn
reviewed
Nov 25, 2024
| "openapi-to-postmanv2": "4.24.0" | ||
| }, | ||
| "devDependencies": { |
There was a problem hiding this comment.
can be done as a follow up but let's make sure dependabot tracks this file
gssbzn
reviewed
Nov 25, 2024
| with: | ||
| node-version: '20.x' | ||
| - name: Install npm dependencies | ||
| uses: nick-fields/retry@v3 |
There was a problem hiding this comment.
rather than retry can you enable cache for setup node https://github.com/actions/setup-node?tab=readme-ov-file#caching-global-packages-data
There was a problem hiding this comment.
Done, also updated the same on the req spec validations workflow 👍
gssbzn
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Jira ticket: CLOUDP-286235
Running locally:
Further comments
We can consider running the existing spectral linting with the package.json instead of a makefile (planned approach for new ipa validator)