Skip to content

DRIVERS-2477: use w:'majority' in consecutive resume change stream tests #1323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

DRIVERS-2477: use w:'majority' in consecutive resume change stream tests #1323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions source/change-streams/tests/unified/change-streams.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1650,6 +1650,9 @@
"arguments": {
"document": {
"x": 1
},
"writeConcern": {
"w": "majority"
}
}
},
Expand All @@ -1659,6 +1662,9 @@
"arguments": {
"document": {
"x": 2
},
"writeConcern": {
"w": "majority"
}
}
},
Expand All @@ -1668,6 +1674,9 @@
"arguments": {
"document": {
"x": 3
},
"writeConcern": {
"w": "majority"
}
}
},
Expand Down
6 changes: 6 additions & 0 deletions source/change-streams/tests/unified/change-streams.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -854,14 +854,20 @@ tests:
object: *globalCollection0
arguments:
document: { x: 1 }
writeConcern:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we leave a comment above this writeConcern to explain that this is needed to make sure the insert propagates and a change stream event is present on all oplogs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, will do!

w: 'majority'
- name: insertOne
object: *globalCollection0
arguments:
document: { x: 2 }
writeConcern:
w: 'majority'
- name: insertOne
object: *globalCollection0
arguments:
document: { x: 3 }
writeConcern:
w: 'majority'
- name: iterateUntilDocumentOrError
object: *changeStream0
expectResult:
Expand Down
9 changes: 9 additions & 0 deletions source/unified-test-format/tests/valid-pass/poc-change-streams.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,9 @@
"arguments": {
"document": {
"x": 1
},
"writeConcern": {
"w": "majority"
}
}
},
Expand All @@ -310,6 +313,9 @@
"arguments": {
"document": {
"x": 2
},
"writeConcern": {
"w": "majority"
}
}
},
Expand All @@ -319,6 +325,9 @@
"arguments": {
"document": {
"x": 3
},
"writeConcern": {
"w": "majority"
}
}
},
Expand Down
6 changes: 6 additions & 0 deletions source/unified-test-format/tests/valid-pass/poc-change-streams.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,14 +172,20 @@ tests:
object: *collection1
arguments:
document: { x: 1 }
writeConcern:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing here.

w: 'majority'
- name: insertOne
object: *collection1
arguments:
document: { x: 2 }
writeConcern:
w: 'majority'
- name: insertOne
object: *collection1
arguments:
document: { x: 3 }
writeConcern:
w: 'majority'
- name: iterateUntilDocumentOrError
object: *changeStream0
expectResult:
Expand Down