Skip to content

Conversation

baileympearson
Copy link
Contributor

Reverts #1633

Copy link
Contributor

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the PR. Verified with the Go driver.

@baileympearson
Copy link
Contributor Author

@kevinAlbs

I ran these tests again this afternoon but they're still failing for me. https://parsley.mongodb.com/evergreen/mongo_node_driver_next_rhel8_test_serverless_proxy_test_serverless_patch_7fde8ddc869623e9df3ea7753a46cae8d6e3e9dd_670d880d2f9f3800076e7917_24_10_14_21_07_26/0/task?bookmarks=0,3536

Are you sure that the compact-v2 test ran in your Go driver CI run?

@kevinAlbs kevinAlbs self-requested a review October 15, 2024 20:05
@baileympearson baileympearson marked this pull request as ready for review October 29, 2024 17:15
@baileympearson baileympearson requested a review from a team as a code owner October 29, 2024 17:15
Copy link
Contributor

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that the compact-v2 test ran in your Go driver CI run?

The test passed on a local run. It turns out, I incorrectly created the cluster with US_EAST_1 region. The driver tests expect US_EAST_2 to create serverless instances with a load balancer fronting single proxy. When creating with US_EAST_2, I saw the same error.

The Atlas team helped to update the instance (see thread in #ask-cloud-atlas-serverless).

Rerunning the Node tests resulted in two other test failures. The fle2v2-Rangev2-Compact test now passes. The other test failures can be addressed separately.

@baileympearson baileympearson merged commit 9058491 into master Oct 29, 2024
3 checks passed
@baileympearson baileympearson deleted the revert-1633-add-skip.DRIVERS-2776 branch October 29, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants