Skip to content

Conversation

kevinAlbs
Copy link
Contributor

Summary

This PR includes minor clarifications (e.g. typos) found when implementing in the C driver:

  • Fix casing: SaslStart => saslStart
  • Fix OIDC prose test 4.3: find => insert
    • Test sets a failpoint on insert and expects an error after.
  • Fix auth code example: re-raise a non-auth error to match the described algorithm.

Please complete the following before merging:

  • [ ] Update changelog.
  • [ ] Test changes in at least one language driver.
  • [ ] Test these changes against all server versions and topologies (including standalone, replica set, and sharded
    clusters).

Re-raise a non-auth error to match the described algorithm and PyMongo implementation.
Test sets a failpoint on `insert` and expects an error after.
@kevinAlbs kevinAlbs requested a review from blink1073 September 15, 2025 19:21
@kevinAlbs kevinAlbs marked this pull request as ready for review September 15, 2025 19:21
@kevinAlbs kevinAlbs requested a review from a team as a code owner September 15, 2025 19:21
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kevinAlbs kevinAlbs merged commit 3dc84d1 into mongodb:master Sep 16, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants