-
Notifications
You must be signed in to change notification settings - Fork 246
DRIVERS-3294 Update $lookup
prose test to support 8.2+
#1846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
connorsmacd
wants to merge
13
commits into
mongodb:master
Choose a base branch
from
connorsmacd:DRIVERS-3294
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+40
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
approved these changes
Oct 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server 8.2 supports mixing QE and non-CSFLE JSON schema validators (SERVER-100260). This PR updates the
$lookup
prose test accordingly.Case 8:
db.csfle
joinsdb.qe
MONGOCRYPT-793 changes
libmongocrypt
's behavior to no longer error when QE and CSFLE schemas are mixed. While it is still an error if the CSFLE schema containsencrypt
validators, the error now comes from the query analysis component with a different message. The test case now specifies different expected error substrings depending on the version of the query analysis component.Case 10:
db.qe
joinsdb.non_csfle_schema
(new)This tests that a
$lookup
with a both QE and non-CSFLE JSON schema validators completes successfully.C Driver Reference Implementations:
libmongocrypt
1.16.0libmongocrypt
1.17.0Please complete the following before merging:
clusters).