Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update adorable api to api.hello-avatar.com #4778

Merged
merged 3 commits into from
Jan 13, 2021

Conversation

wipash
Copy link

@wipash wipash commented Jan 9, 2021

Resolves #4777

The Adorable.io avatar API has been closed down: itsthatguy/avatars-api-middleware#108 (comment)

This PR switches the URL to https://api.hello-avatar.com/adorables/ to immediately get the avatars working again.
See: itsthatguy/avatars-api-middleware#108 (comment)

@CLAassistant
Copy link

CLAassistant commented Jan 9, 2021

CLA assistant check
All committers have signed the CLA.

@asbiin
Copy link
Member

asbiin commented Jan 9, 2021

I love it!
Could you also create a database update to fix all existing adorable urls?
If you don't know how, I can help.

@wipash
Copy link
Author

wipash commented Jan 10, 2021

Sure thing. I don't know how, but I'll try it tonight.

@wipash wipash marked this pull request as draft January 10, 2021 11:37
@wipash wipash marked this pull request as ready for review January 10, 2021 21:00
@wipash
Copy link
Author

wipash commented Jan 10, 2021

Okay! The migration is working in homestead. Is this the right approach?

@asbiin asbiin merged commit 527131e into monicahq:master Jan 13, 2021
@asbiin
Copy link
Member

asbiin commented Jan 13, 2021

Thank you @wipash !

@wipash wipash deleted the 4777-update-adorable-api branch January 13, 2021 23:15
@wipash
Copy link
Author

wipash commented Jan 13, 2021

Awesome! Thank you so much @asbiin for being so kind and welcoming, even though this was a tiny change. Contributing for the first time to an open project like this is pretty daunting, but you made the experience feel very friendly.

@djaiss
Copy link
Member

djaiss commented Feb 20, 2021

@asbiin the hello-avatar api seems down. Can you confirm?

@asbiin
Copy link
Member

asbiin commented Feb 20, 2021

@djaiss no, it's working well:

@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adorable Avatar API has been closed down
4 participants