Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 people tags filter link #5568

Merged
merged 2 commits into from
Oct 8, 2021

Conversation

nhymxu
Copy link

@nhymxu nhymxu commented Oct 5, 2021

Close #5566

Checklist

Before submitting the PR

  • Read the CONTRIBUTING document before submitting your PR.
  • If the PR is related to an issue or fix one, don't forget to indicate it.
  • Create your PR as draft if it is not final yet. Mark it as ready... when it’s ready. Otherwise the PR will be considered complete and rejected if it's not working.

General checks

  • Make sure that the change you propose is the smallest possible.
  • The name of the PR should follow the conventional commits guideline that the project follows.

Front-end changes

  • If you change the UI, make sure to ask repositories administrators first about your changes by pinging djaiss or asbiin in this PR.
  • Screenshots are included if the PR changes the UI.
  • Front-end tests have been written with Cypress.

Backend/models changes

  • The API has been updated.
  • API's documentation has been added by submitting a pull request in the marketing website repository.
  • Tests have been added for the new code.
  • If you change a model, make sure the SetupTest file is updated. We need seeders to develop locally and generate fake data.

If the code changes the SQL schema

  • Make sure exporting account data as SQL is still working.
  • Make sure your changes do not break importing data with vCard and .csv files.
  • Make sure account reset and deletion still work.

Other tasks

  • CONTRIBUTORS entry added, if necessary.
  • If it's relevant and worth mentioning, create a changelog entry for this change. The changelog entry will appear inside the UI for all users to see. To know if your change is worth the creation of a changelog entry, read the documentation.
  • Don't forget to ask for a free account on https://monicahq.com as anyone who contributes can request a free account.

@nhymxu nhymxu force-pushed the 5566-fix-bug-people-tags-link branch from b969cb0 to b0c23e4 Compare October 5, 2021 16:00
@nhymxu nhymxu marked this pull request as ready for review October 5, 2021 16:05
@asbiin asbiin merged commit 0cabd16 into monicahq:master Oct 8, 2021
@asbiin
Copy link
Member

asbiin commented Oct 8, 2021

Thank you @nhymxu

@github-actions
Copy link

github-actions bot commented Oct 9, 2021

🎉 This PR is included in version 3.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nhymxu nhymxu deleted the 5566-fix-bug-people-tags-link branch October 9, 2021 07:52
@nhymxu nhymxu restored the 5566-fix-bug-people-tags-link branch November 20, 2021 13:40
@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/people click on tag bug
2 participants