Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: carddav client #3851

Merged
merged 121 commits into from
Sep 20, 2021
Merged

feat: carddav client #3851

merged 121 commits into from
Sep 20, 2021

Conversation

asbiin
Copy link
Member

@asbiin asbiin commented Apr 16, 2020

This depends on #3749
It will close #2738

This adds the ability to add an external carddav source, and sync contacts in a new address book.
There are 2 steps

  • Add a new address book: this is currently done with a new Command monica:newaddressbooksubscription. A dedicated UI will be added later in another PR.
  • Sync the contacts: this is done by a new schedule command, based on a frequency

Limitations

  • Second address book is not displayed in Monica today. This has to be done in another PR
  • The external carddav server must respect standards.
    For instance, this is not the case of google api... Hopefully I managed how to handle this specific case, but we will not add further exceptions.
  • When adding multiple address books (Monica comes with at least 1 default address book per account), there is no way to "merge" duplicates (= same contact in different address books). This has to be done in another PR
  • There is no way to handle errors: if an address book sync has an error, it's logged in the app logs, but this it not accessible by the user, and new sync will be triggered again and again.

@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

87.8% 87.8% Coverage
0.0% 0.0% Duplication

@asbiin asbiin merged commit e6c92cf into master Sep 20, 2021
@asbiin asbiin deleted the 2020-03-22-carddav-client branch September 20, 2021 20:54
@cstrat
Copy link

cstrat commented Sep 21, 2021

Do you know if this update will address #5150 ??

Sorry I just realised this is to add a carddav client to Monica, thats cool!
Probably doesn't update the carddav server which is serving contacts out right?

@github-actions
Copy link

github-actions bot commented Oct 9, 2021

🎉 This PR is included in version 3.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sitarane
Copy link

sitarane commented Jan 2, 2022

Hey, sorry to reanimate this thread, but I've been trying to figure out how to use this feature for a few days and I can't get my head around it.
If I understand well, this merged PR means that Monica can now get contacts from a third party CardDAV server, my usecase would be Nextcloud.
How do I point Monica to a CardDAV server?

@daniele-athome
Copy link

I can't find any documentation about it, but a user tried: #5654

@daniele-athome
Copy link

By the way is the synchronization one-way? Meaning CalDAV data is only read from the server, right?

@cstrat
Copy link

cstrat commented May 23, 2022

I am finding strange behaviour where my Monica contacts on my iPhone over time simply duplicate themselves.
I need to disconnect Monica from my Contacts, let it purge my contact list, then re-enable it and sync again.

@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CardDAV Client Support
7 participants