Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed formula reference issues #118

Merged
merged 1 commit into from
Jul 13, 2018
Merged

fixed formula reference issues #118

merged 1 commit into from
Jul 13, 2018

Conversation

apixandru
Copy link
Contributor

@apixandru apixandru commented Oct 27, 2017

This pull request fixes two issues

  1. Formulas that operated on numbers were being converted to string.

In StreamingWorkbookTest#testFormulaCells we had cells A1 with value 1 and A2 with value 2, cell A3 which was sum of A1 and A2 had value "3" instead of 3

  1. Formulas that included dates were losing the date format

For instance in StreamingWorkbookTest#testNumericFormattedFormulaCell we had cells C1 with value May 11 2018 and C2 with value C1 was returning "43231" which is the numeric value of C1, unformatted and also converted to a string

In my opinion, since this is likely to cause a regression on people expecting the old behavior, It would probably be a good idea to increment the major version or at least the minor one.

@apixandru
Copy link
Contributor Author

anyone alive in here? :)

@monitorjbl
Copy link
Owner

Sorry, started a new job and I haven't had much time to review these PRs. I agree that this will need a version bump. I'm going to hold off merging this until I can get the other changes released.

@apixandru
Copy link
Contributor Author

No worries, I just wanted to make sure that someone had a chance to look over this. I have rebased the change on top of the new code changes to solve the conflicts.

@siddharth96
Copy link

Any update on when this change can be merged?

@monitorjbl monitorjbl merged commit c315b68 into monitorjbl:master Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants