Fixed StreamingRow.getLastCellNum() #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… physical number of cells + 1, not the index of the last cell. Also implemented getPhysicalNumberOfCells()
|
Sorry for taking so long to get around to reviewing this, looks good to me! |
|
Thanks!
*Todd Warwaruk*
Platform Architect
Trax Technologies, Inc.
M: 480-206-5458
TraxTech.Com <http://traxtech.com/>
<https://www.linkedin.com/company/trax-technologies>
<https://twitter.com/TraxTech>
<https://plus.google.com/+TraxTechnologiesScottsdale>
<https://www.youtube.com/channel/UC3dLvg5LNV9ot6pgdQluw5g>
…On Fri, Nov 25, 2016 at 8:55 AM, Taylor Jones ***@***.***> wrote:
Sorry for taking so long to get around to reviewing this, looks good to me!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#61 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHLXa73PpZctNZKmPmWnrMfWk8khtRPNks5rBwUIgaJpZM4Ko4Hj>
.
--
CONFIDENTIALITY NOTICE: The preceding and/or attached information may be
confidential or privileged. It should be used or disseminated solely for
the purpose of conducting business with Trax. If you are not an intended
recipient, please notify the sender by replying to this message and then
delete the information from your system. Thank you for your cooperation.
|
rimuln
pushed a commit
to rimuln/excel-streaming-reader
that referenced
this pull request
Nov 15, 2021
Bumps [maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 3.3.0 to 3.3.1. - [Release notes](https://github.com/apache/maven-javadoc-plugin/releases) - [Commits](apache/maven-javadoc-plugin@maven-javadoc-plugin-3.3.0...maven-javadoc-plugin-3.3.1) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-javadoc-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of StreamingRow.getLastCellNum() was returning the number of physical cells + 1, it was not returning the index + 1 of the last cell. I also implemented StreamingRow.getPhysicalNumberOfCells()