Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement BIO.wanderN from Monix Task #23

Closed
Avasil opened this issue Dec 10, 2019 · 1 comment
Closed

Implement BIO.wanderN from Monix Task #23

Avasil opened this issue Dec 10, 2019 · 1 comment
Labels
good first issue Good for newcomers
Milestone

Comments

@Avasil
Copy link
Contributor

Avasil commented Dec 10, 2019

Please put the method in other companion objects as well (Task, UIO) with appropriate return type if it applies

General flow:

  • Comment in this issue to let others know that someone is working on it
  • Copy scaladoc and the implementation from Monix Task in similar place
  • Modify signature to take advantage of typed errors if possible
  • Implementation might require some changes, in most cases the compiler should guide you, also look for already ported operators for inspiration. The most common change is to use BiCallback instead of Callback to be able to signal errors on two different channels ("typed" channel and hidden channel for "fatal" errors).
  • Copy the corresponding tests from Monix. Try to use BIO instead of Task with E different than Throwable when possible to uncover any possible bugs in the internals.
  • If you test for a failure, try to test for both "expected" failure (error from E, it will be CancelableFuture(Left)) after runToFuture) and "fatal" failure (it will be a failed CancelableFuture).
  • Take a look at the existing tests to see if there aren't any commented ones using newly implemented function and uncomment them.

Don't be shy to ping me if you need any advice or want to consult the solution. I really appreciate the involvement and I'm happy to help!

@Avasil Avasil added the good first issue Good for newcomers label Dec 10, 2019
@Avasil Avasil added this to the 0.1.0 milestone Jan 11, 2020
@pjurczenko
Copy link
Contributor

I'll work on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants