Introduce BIO.wanderN
#101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjurczenko
commented
Mar 10, 2020
| import scala.concurrent.duration._ | ||
| import scala.util.{Failure, Success} | ||
|
|
||
| object TaskWanderNSuite extends BaseTestSuite { |
There was a problem hiding this comment.
@Avasil: Original .wanderN implementation didn't have any tests, so I've created a few. Do you think it might be worth porting them to the original project as well?
There was a problem hiding this comment.
Tests rarely hurt so I don't see why not. We probably don't need that many though - implementation is very simple.
Avasil
approved these changes
Mar 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #23.