Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated all gatherX and wanderX methods to be parSequenceX and parTra… #102

Merged
merged 10 commits into from
Mar 30, 2020
Merged

Updated all gatherX and wanderX methods to be parSequenceX and parTra… #102

merged 10 commits into from
Mar 30, 2020

Conversation

Executioner1939
Copy link
Contributor

@Executioner1939 Executioner1939 commented Mar 28, 2020

#75

@Avasil I see we don't have a TaskDeprecated object like monix.eval. I hope what I have done is correct.

I can add and implement the same Deprecation Strategy if you would like?

Please let me know if I should fix it :-)

@Avasil
Copy link
Contributor

Avasil commented Mar 28, 2020

Thanks @Executioner1939 :)

I just merged #101 with wanderN - could you add parTraverseN too?

I can add and implement the same Deprecation Strategy if you would like?

Yes please, I didn't setup MiMa yet but I intend to keep binary compatibility here as well. We probably need similar mechanism for aliases (Task, UIO)

@Executioner1939
Copy link
Contributor Author

@Avasil I have updated the PR :-).

I added three objects BIODeprecated, UIODeprecated and TaskDeprecated. I hope this is okay, I also set the deprecation since version to 0.1.0 not sure if it should be the next version number? If so are we just bumping up to 0.2.0?

@Executioner1939
Copy link
Contributor Author

@Avasil Hi :-). Anything I need to rectify here?

Copy link
Contributor

@Avasil Avasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's perfect - thank you :)

@Avasil
Copy link
Contributor

Avasil commented Mar 30, 2020

I also set the deprecation since version to 0.1.0 not sure if it should be the next version number? If so are we just bumping up to 0.2.0?

I plan to keep 0.1.x until we break binary compatibility so it should be probably 0.1.1 but we'll see

@Avasil Avasil merged commit 776fe9c into monix:master Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants