Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add convenience methods to IO like .when #172

Merged
merged 2 commits into from
Sep 25, 2020
Merged

Add convenience methods to IO like .when #172

merged 2 commits into from
Sep 25, 2020

Conversation

VladPodilnyk
Copy link
Contributor

Hi!
This meant to solve #159

@VladPodilnyk
Copy link
Contributor Author

@Avasil, I could do the same for monix/monix#1243 in case this PR will be approved.

Avasil
Avasil reviewed Sep 25, 2020
View reviewed changes
Copy link
Contributor

@Avasil Avasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you a lot for your contribution! 👍

core/shared/src/main/scala/monix/bio/Task.scala Show resolved Hide resolved
core/shared/src/main/scala/monix/bio/IO.scala Outdated Show resolved Hide resolved
core/shared/src/main/scala/monix/bio/IO.scala Outdated Show resolved Hide resolved
@VladPodilnyk
Copy link
Contributor Author

Thank you a lot for your contribution! 👍

Thank you for doing this project in the first place 😊

Avasil
Avasil approved these changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@Avasil Avasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I will appreciate if you do a similar PR for monix/monix

@Avasil Avasil merged commit a806184 into monix:master Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avasil Avasil Avasil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VladPodilnyk @Avasil