Add seekToBeginning option, reuse instances of kafka (de)serializers #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasil
commented
Apr 2, 2020
| @@ -249,6 +249,7 @@ final case class KafkaConsumerConfig( | |||
| observableCommitType: ObservableCommitType, | |||
| observableCommitOrder: ObservableCommitOrder, | |||
| observableSeekToEndOnStart: Boolean, | |||
| observableSeekToBeginningOnStart: Boolean, | |||
There was a problem hiding this comment.
Will probably change to ADT, I need to decide whether I want to break it or not
There was a problem hiding this comment.
It would be nice to have this change before final release.
yeryomenkom
approved these changes
Apr 7, 2020
| @@ -249,6 +249,7 @@ final case class KafkaConsumerConfig( | |||
| observableCommitType: ObservableCommitType, | |||
| observableCommitOrder: ObservableCommitOrder, | |||
| observableSeekToEndOnStart: Boolean, | |||
| observableSeekToBeginningOnStart: Boolean, | |||
There was a problem hiding this comment.
It would be nice to have this change before final release.
|
@Avasil Hi! Thank you for this PR. Seems good! |
|
Thanks @yeryomenkom - I will finish it and will do a release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #175
Fixes #90
@yeryomenkom is that what you had in mind?