-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Replace JSON.parse with parseJsonWithSchema (@dev-mohit06) #6207
base: master
Are you sure you want to change the base?
refactor: Replace JSON.parse with parseJsonWithSchema (@dev-mohit06) #6207
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dev-mohit06, nice work. I added some comments for you.
…WithSchema (@dev-mohit06) - Updated schema definitions for better clarity and reusability. - Replaced with where applicable. - Addressed all review comments for better code consistency.
Hey @fehmer, could you take a look at the changes? |
Hey @fehmer, could you take a look at the changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dev-mohit06 , changes look good. Please remove the code comment on the unresolved PR comment or replace with the suggested comments.
Thank you for your contribution. Do you want to take the backend part next?
Hi @fehmer, Thank you for the feedback! I’ll address the code comment as suggested. Regarding the backend part, I’d be happy to take it up. Could you please share the details or scope of the task? |
Same as for the frontend for the files |
Hi @fehmer, thank you for the feedback! I’ll address the code comment and work on the backend implementation as well. By the way, could you let me know when this PR will be merged? |
Hi @fehmer, just wanted to follow up regarding the PR. Let me know if there’s anything else needed from my side or an update on the merge timeline. Thanks! |
@Miodec could you tell me what should i need to do next? |
hi @dev-mohit06 , your PR looks good from my side. next mio will review and merge when he has time. You don't need to follow up or rebase unless requested. Thanks for your contribution |
@fehmer, you mentioned the backend file changes. I’ve completed those updates. Should I create the PR now? |
Ive been sick with some kind of flu lately. Please just be patient, Ill get to all PRs eventually. |
@Miodec No worries! Take your time and focus on getting better. |
Description
Replaces raw JSON parsing with schema-based validation across frontend TypeScript files to improve type safety and error handling.
Scope of Changes
Updated JSON parsing in:
account.ts
import-export-settings.ts
analytics-controller.ts
local-storage-with-schema.ts
url-handler.ts
commandline/lists.ts
test/wikipedia.ts
Added schema in
test/custom-text.ts
:Benefits
Checks