Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(language): add Bulgarian Latin (@ShinniUwU) #6226

Merged
merged 8 commits into from
Feb 12, 2025

Conversation

ShinniUwU
Copy link
Contributor

Description

This PR adds Bulgarian Latin as a new language to Monkeytype. Bulgarian Latin is commonly used by Bulgarians who do not have access to a Cyrillic keyboard.

  • Added bulgarian-latin.json with 200 words.
  • Updated _list.json and _groups.json to include Bulgarian Latin.
  • Ensured JSON formatting follows standards.

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • Edited _list.json, _groups.json, and added bulgarian-latin.json.
    • Not a theme, so no theme.css needed.
  • Check if any open issues are related to this PR.
  • PR title follows Conventional Commits standard:
    feat(language): add Bulgarian Latin (@ShinniUwU)

Closes

N/A (unless there’s an existing issue related to Bulgarian Latin—then reference it here)

Final PR Title Example:

feat(language): add Bulgarian Latin (@ShinniUwU)

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Jan 31, 2025
…rom Bulgarian Latin
Copy link
Member

@Miodec Miodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change - to _ in the file name.

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Feb 3, 2025
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Feb 10, 2025
@ShinniUwU
Copy link
Contributor Author

Please change - to _ in the file name.

Sorry for the wait! I’ve made the requested changes bulgarian-latin is now bulgarian_latin in both _list.json and _groups.json. Let me know if anything else needs adjusting. Thanks for the review

Copy link
Member

@Miodec Miodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Miodec Miodec merged commit d8ca416 into monkeytypegame:master Feb 12, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants