Skip to content

Conversation

@mattleibow
Copy link
Contributor

@mattleibow mattleibow commented Apr 19, 2020

Description of Change

Expose a generic, writable span for the pixels. Also "cache" the info object in size so we don' have to hop the interop.

Bugs Fixed

API Changes

class SKPixmap {
    public unsafe Span<T> GetPixelSpan<T> () where T : unmanaged;
}

Behavioral Changes

None.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Updated documentation

Fixes #1240
Also "cache" the info object in size so we don' have to hop the interop.
ziriax
ziriax previously approved these changes Apr 19, 2020
Copy link
Contributor

@ziriax ziriax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems perfect at first sight :)

@mattleibow mattleibow merged commit 290b61e into master Apr 23, 2020
@mattleibow mattleibow deleted the dev/fix-1240 branch April 23, 2020 00:02
@mattleibow mattleibow added this to the v1.68.2 milestone Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[QUESTION] Is SKPixMap.GetPixelSpan supposed to be readonly?

3 participants