Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the signing template #2946

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Update the signing template #2946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions scripts/SignList.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,9 @@
<!-- <Skip Include="System.*.dll" /> -->
</ItemGroup>

<ItemGroup>
<MacDeveloperSign Include="libSkiaSharp.dylib" />
<MacDeveloperSign Include="libHarfBuzzSharp.dylib" />
</ItemGroup>

</Project>
7 changes: 6 additions & 1 deletion scripts/azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ parameters:
displayName: 'Run post-build compliance tasks (such as API Scan and PoliCheck)'
type: boolean
default: false
- name: forceRealSigning
displayName: 'Ignore all logic and force Real signing on binaries'
type: boolean
default: false

variables:
- template: /scripts/azure-pipelines-variables.yml@self
Expand Down Expand Up @@ -78,6 +82,7 @@ extends:
buildExternals: ${{ parameters.buildExternals }}
${{ if and(eq(variables['System.TeamProject'], 'devdiv'), ne(variables['System.PullRequest.IsFork'], 'true')) }}:
enableSigning: true
forceRealSigning: ${{ parameters.forceRealSigning }}
${{ if or(parameters.runCompliance, and(eq(variables['Build.Reason'], 'Schedule'), or(eq(variables['Build.SourceBranch'], 'refs/heads/main'), startsWith(variables['Build.SourceBranch'], 'refs/heads/release/')))) }}:
sdl:
apiscan:
Expand Down Expand Up @@ -107,4 +112,4 @@ extends:
buildAgentMac: ${{ parameters.buildAgentMac }}
buildAgentMacNative: ${{ parameters.buildAgentMac }}
buildAgentLinux: ${{ parameters.buildAgentLinux }}
buildAgentLinuxNative: ${{ parameters.buildAgentLinux }}
buildAgentLinuxNative: ${{ parameters.buildAgentLinux }}
9 changes: 6 additions & 3 deletions scripts/azure-templates-stages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ parameters:
- name: enableSigning
type: boolean
default: false
- name: forceRealSigning
type: boolean
default: false

stages:
- stage: prepare
Expand Down Expand Up @@ -661,11 +664,11 @@ stages:
displayName: Sign NuGets
dependsOn: package
jobs:
- template: sign-artifacts/jobs/v2.yml@xamarin-templates
- template: sign-artifacts/jobs/v3.yml@xamarin-templates
parameters:
${{ if or(eq(variables['Build.SourceBranch'], 'refs/heads/main'), startsWith(variables['Build.SourceBranch'], 'refs/heads/release/')) }}:
${{ if or(eq(parameters.forceRealSigning, 'true'), eq(variables['Build.SourceBranch'], 'refs/heads/main'), startsWith(variables['Build.SourceBranch'], 'refs/heads/release/')) }}:
signType: 'Real'
${{ if not(or(eq(variables['Build.SourceBranch'], 'refs/heads/main'), startsWith(variables['Build.SourceBranch'], 'refs/heads/release/'))) }}:
${{ else }}:
signType: 'Test'
use1ESTemplate: ${{ parameters.use1ESPipelineTemplates }}
usePipelineArtifactTasks: true
Expand Down
Loading