Linux build version script to hide exports of dependencies #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
requested changes
Oct 17, 2019
Co-Authored-By: Matthew Leibowitz <mattleibow@live.com>
|
I see an error:
|
|
Let me fire up a VM quick |
|
I think it was missing the last semicolon... Updated the code, so let's see. Took a guess from the sample in https://www.gnu.org/software/gnulib/manual/html_node/LD-Version-Scripts.html |
|
Should have tested this after I rewrote everything from scratch :( |
|
Do you use a VM of WSL? |
|
Using a VM and running Ubuntu 18.04 LTS. Did a fresh clone. Let me check real quick what is happening. |
|
Seems to have passed the build of libSkiaSharp for Linux. |
|
Y same on my machine. Looks okay now. |
|
I wonder why Fontconfig is still exported. There seems to be a version script for glibc as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Currently symbols of Freetype etc. are exported during the linker process. This leads to errors when used with applications that load build in third party libraries.
Bugs Fixed