-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to a much later version of skia (m80) #986
Conversation
native-builds/libHarfBuzzSharp_windows/libHarfBuzzSharp.vcxproj
Outdated
Show resolved
Hide resolved
876b986
to
53b079d
Compare
* UWP: Fix the ARM build and add ARM64 * GDI is optional - and we don't want it * Fix windows projects * Update harfbuzz to v2.6.2 * Use Docker * Use a later version of the linux bits * Use VS 2019 * Create install-vs.ps1 * Use Xcode 11 * Update the tooling * Update skia
2fc43be
to
4e7fe1c
Compare
4e7fe1c
to
39d1d30
Compare
74d3cc8
to
f3dfa35
Compare
In my opinion SKFont should only measure and break spans of glyphs. Supplying a string to these methods leads to errors. This only works for text that doesn't need extra shaping when you supply a string. |
@Gillibald I agree. I just have to add it back for backwards compat 😢 However... I can just keep SKFont to be glyph-only... Doesn't the Finally, even though you and I know that we need to get glyphs, many people just want to use simple .NET strings as text... |
Y all these methods should follow this logic. I consider SKFont a low level component. SKPaint can expose overloads that take a string. SKFont doesn't need that and should do better. Maybe we should document it somehow that this only works for basic scenarios and link to the SkShaper component. Edit: This also doesn't handle surrogate pairs if I am not mistaken but that might be wrong. |
I think it does, which is actually quite nice (or maybe I am mistaken): https://github.com/google/skia/blob/chrome/m80/src/utils/SkUTF.cpp#L70-L94 And I think I agree with that logic of keeping |
Description of Change
Update to the latest (m80 at this time) version of skia.
This has been published that to the internal feed as 2.80.0-pr.986.37
Tasks
Bugs Fixed
API & Behavioral Changes
Changes so far (excluding the changes listed in mono/skia#64):