-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retain full assembly information for forwarded types #342
Comments
Can we add some attributes to this information so that we can filter type forwards from the UI? |
@mairaw type forwards or assembly information for forwarded types? |
Let's look at my example workaround. If we fix this just by adding the assembly to the list as we do with the other regular assemblies: We end up with the whole list of assemblies in the UI and in the metadata: Ideally, this assembly info for forwarded types should only show up in the metadata and not in the UI. That's why I'm asking you to distinguish the assemblies we have there right now which is their true location and these implementation details that only matter to us internally. |
But as usual, I'm open to take a two- or even three- phase approach if needed. Where first we fix the most immediate issue which is recognizing the type forwards assemblies, and then later we recognize the true assemblies and filter them out from the UI. |
Hiding the assembly from the view is something we need to address on our side. @joelmartinez - something to consider here is potentially adding an attribute to the assembly node, something like |
Well, it's not quite as simple as that ... because the assemblies don't currently have any indication of what framework they're a part of (see #103). So there might be a scenario, where a type is present in some assembly in one framework, is forwarded from that assembly in another. So for example (this is truly an example, I don't know if this kind of graph exists anywhere/currently, but it might):
In that case, a naive implementation would make OR we could simply list all assemblies, without any kind of additional metadata ... and then on the front-end we could filter those out entirely (by virtue of having the "truth" listed via #103 in the |
Yes, I understand is not easy. Let's start with the solution that lists all assemblies and we go from there. |
Also, now caching assembly directories for resolution. Related to #342
Also, now caching assembly directories for resolution. Related to #342
As an example,
System.Net.WebResponse
is forwarded fromSystem.Net.dll
, thereforeSystem.Net.dll
is not included in the list of assemblies that show the origin of the API. The request is to include the full list of assemblies in the final ECMAXML output.The text was updated successfully, but these errors were encountered: