Skip to content

WinRT migration - C++/WinRT signature differences #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2020
Merged

WinRT migration - C++/WinRT signature differences #497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mdoc/Mono.Documentation/Updater/Formatters/CppFormatters/CppWinRtFullMemberFormatter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ protected override string GetTypeKind(TypeDefinition t)
if (t.IsClass)
return "class";
if (t.IsInterface)
return "__interface";
return "struct";
throw new ArgumentException(t.FullName);
}

Expand Down
2 changes: 1 addition & 1 deletion mdoc/Test/en.expected-cppwinrt2/Mono.DocTest.Generic/IFoo`1.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Type Name="IFoo&lt;T&gt;" FullName="Mono.DocTest.Generic.IFoo&lt;T&gt;">
<TypeSignature Language="C#" Value="public interface IFoo&lt;T&gt;" />
<TypeSignature Language="ILAsm" Value=".class public interface auto ansi abstract IFoo`1&lt;T&gt;" />
<TypeSignature Language="C++ WINRT" Value="template &lt;typename T&gt;&#xA;__interface IFoo" />
<TypeSignature Language="C++ WINRT" Value="template &lt;typename T&gt;&#xA;struct IFoo" />
<AssemblyInfo>
<AssemblyName>DocTest</AssemblyName>
<AssemblyVersion>0.0.0.0</AssemblyVersion>
Expand Down
2 changes: 1 addition & 1 deletion mdoc/Test/en.expected-cppwinrt2/Mono.DocTest/IProcess.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Type Name="IProcess" FullName="Mono.DocTest.IProcess">
<TypeSignature Language="C#" Value="public interface IProcess" />
<TypeSignature Language="ILAsm" Value=".class public interface auto ansi abstract IProcess" />
<TypeSignature Language="C++ WINRT" Value="__interface IProcess" />
<TypeSignature Language="C++ WINRT" Value="struct IProcess" />
<AssemblyInfo>
<AssemblyName>DocTest</AssemblyName>
<AssemblyVersion>0.0.0.0</AssemblyVersion>
Expand Down
2 changes: 1 addition & 1 deletion mdoc/Test/en.expected-cppwinrt2/Mono.DocTest/Widget+IMenuItem.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Type Name="Widget+IMenuItem" FullName="Mono.DocTest.Widget+IMenuItem">
<TypeSignature Language="C#" Value="public interface Widget.IMenuItem" />
<TypeSignature Language="ILAsm" Value=".class nested public interface auto ansi abstract Widget/IMenuItem" />
<TypeSignature Language="C++ WINRT" Value="__interface Widget::IMenuItem" />
<TypeSignature Language="C++ WINRT" Value="struct Widget::IMenuItem" />
<AssemblyInfo>
<AssemblyName>DocTest</AssemblyName>
<AssemblyVersion>0.0.0.0</AssemblyVersion>
Expand Down
2 changes: 1 addition & 1 deletion mdoc/Test/en.expected-eii-implementation-ecmadoc/CustomNamespace/CustomInterface.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<TypeSignature Language="F#" Value="type CustomInterface = interface" />
<TypeSignature Language="C++ CLI" Value="public interface class CustomInterface" />
<TypeSignature Language="C++ CX" Value="public interface class CustomInterface" />
<TypeSignature Language="C++ WINRT" Value="__interface CustomInterface" />
<TypeSignature Language="C++ WINRT" Value="struct CustomInterface" />
<AssemblyInfo>
<AssemblyName>DocTest-VB-Eii</AssemblyName>
<AssemblyVersion>0.0.65535.65535</AssemblyVersion>
Expand Down
2 changes: 1 addition & 1 deletion mdoc/Test/en.expected-eii-implementation-slashdoc/CustomNamespace/CustomInterface.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<TypeSignature Language="F#" Value="type CustomInterface = interface" />
<TypeSignature Language="C++ CLI" Value="public interface class CustomInterface" />
<TypeSignature Language="C++ CX" Value="public interface class CustomInterface" />
<TypeSignature Language="C++ WINRT" Value="__interface CustomInterface" />
<TypeSignature Language="C++ WINRT" Value="struct CustomInterface" />
<AssemblyInfo>
<AssemblyName>DocTest-VB-Eii</AssemblyName>
<AssemblyVersion>0.0.65535.65535</AssemblyVersion>
Expand Down
2 changes: 1 addition & 1 deletion mdoc/Test/en.expected-eii-implementation/CustomNamespace/CustomInterface.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<TypeSignature Language="F#" Value="type CustomInterface = interface" />
<TypeSignature Language="C++ CLI" Value="public interface class CustomInterface" />
<TypeSignature Language="C++ CX" Value="public interface class CustomInterface" />
<TypeSignature Language="C++ WINRT" Value="__interface CustomInterface" />
<TypeSignature Language="C++ WINRT" Value="struct CustomInterface" />
<AssemblyInfo>
<AssemblyName>DocTest-VB-Eii</AssemblyName>
<AssemblyVersion>0.0.65535.65535</AssemblyVersion>
Expand Down
2 changes: 1 addition & 1 deletion mdoc/Test/en.expected/Mono.DocTest.Generic/IFoo`1.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<TypeSignature Language="F#" Value="type IFoo&lt;'T&gt; = interface" />
<TypeSignature Language="C++ CLI" Value="generic &lt;typename T&gt;&#xA;public interface class IFoo" />
<TypeSignature Language="C++ CX" Value="public interface class IFoo" />
<TypeSignature Language="C++ WINRT" Value="template &lt;typename T&gt;&#xA;__interface IFoo" />
<TypeSignature Language="C++ WINRT" Value="template &lt;typename T&gt;&#xA;struct IFoo" />
<AssemblyInfo>
<AssemblyName>DocTest</AssemblyName>
<AssemblyVersion>0.0.0.0</AssemblyVersion>
Expand Down
2 changes: 1 addition & 1 deletion mdoc/Test/en.expected/Mono.DocTest/IProcess.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<TypeSignature Language="F#" Value="type IProcess = interface" />
<TypeSignature Language="C++ CLI" Value="public interface class IProcess" />
<TypeSignature Language="C++ CX" Value="public interface class IProcess" />
<TypeSignature Language="C++ WINRT" Value="__interface IProcess" />
<TypeSignature Language="C++ WINRT" Value="struct IProcess" />
<AssemblyInfo>
<AssemblyName>DocTest</AssemblyName>
<AssemblyVersion>0.0.0.0</AssemblyVersion>
Expand Down
2 changes: 1 addition & 1 deletion mdoc/Test/en.expected/Mono.DocTest/Widget+IMenuItem.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<TypeSignature Language="F#" Value="type Widget.IMenuItem = interface" />
<TypeSignature Language="C++ CLI" Value="public: interface class Widget::IMenuItem" />
<TypeSignature Language="C++ CX" Value="public: interface class Widget::IMenuItem" />
<TypeSignature Language="C++ WINRT" Value="__interface Widget::IMenuItem" />
<TypeSignature Language="C++ WINRT" Value="struct Widget::IMenuItem" />
<AssemblyInfo>
<AssemblyName>DocTest</AssemblyName>
<AssemblyVersion>0.0.0.0</AssemblyVersion>
Expand Down
2 changes: 1 addition & 1 deletion mdoc/mdoc.Test/CppWinRtFormatterTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public void TypeSignature_Struct_Class4()
public void TypeSignature_GenericInterface()
{
TestTypeSignature(typeof(IFoo<>), @"template <typename T>
__interface IFoo");
struct IFoo");
}

[Test]
Expand Down