When importing doc from comment xml, we should clean up existing <al…wo #510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelmartinez
requested changes
Jul 27, 2020
Member
joelmartinez
left a comment
joelmartinez
left a comment
There was a problem hiding this comment.
Offhand, this looks fine ... however two things:
- I'd like to see either a unit test, or integration test that tests this scenario ... so there would be existing content, and then this would be removed for the new content to be added by the importer. Please feel free to refactor this particular section of the code out into maybe a method in DocUtils that can more easily be unit tested.
- Take a look at the linked item in the comments of the devops item ... it's a similar issue with
relatedtags that need to be similarly cleared as what you've done here.
With those changes this would be ready to go :)
maopeixia
force-pushed
the
mpx-mdoc-1.0.2.3
branch
from
7c273b9 to
8b9792c
Compare
joelmartinez
pushed a commit
that referenced
this pull request
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work item: https://ceapex.visualstudio.com/Engineering/_workitems/edit/173471