Sort for assembly files and update expected XML files #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hi @hiihellox10, let's update the commit message and pr description to help others understand why we need this code change. And also the test CI runs for processing https://github.com/dotnet/dotnet-api-docs of not introduce new diff. |
…x10/api-doc-tools into sort-for-assembly-files
joelmartinez
approved these changes
Dec 7, 2020
Member
joelmartinez
left a comment
joelmartinez
left a comment
There was a problem hiding this comment.
This looks great!
@anmeng10101, I can just change the commit message when I do the squash commit :) And as for the changes on dotnet-api-docs, I think we can accept any changes that are just the result of a .dll re-ordering; this will make results much more consistent going forward so it's necessary.
Thanks @hiihellox10!
v-zazhou
pushed a commit
to v-zazhou/api-doc-tools
that referenced
this pull request
Dec 14, 2020
This change brings a higher consistency across environments, as originally the .dlls were read in whatever order the operating system enumerated them in; this proved to be inconsistent over time, so this will reduce unexpected results going forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Directory.GetFiles method returned file names is not sort, this makes the order of the assembly elements of our generated XML files is inconsistent in different environments, so we need to sort it and update those expected XML files.