Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions mdoc/Mono.Documentation/Updater/DocUtils.cs
Original file line number Diff line number Diff line change
Expand Up @@ -928,5 +928,22 @@ public static bool IsEiiIgnoredMethod(MethodReference method, MethodReference im

return false;
}

public static TypeDefinition FixUnnamedParameters(TypeDefinition type)
{
foreach (var method in type.Methods)
{
var unnamedParameterIndex = 1;
foreach (var item in method.Parameters)
{
if (string.IsNullOrEmpty(item.Name))
{
item.Name = $"unnamedParam{unnamedParameterIndex++}";
}
}
}

return type;
}
}
}
2 changes: 1 addition & 1 deletion mdoc/Mono.Documentation/Updater/DocumentationEnumerator.cs
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ protected IEnumerable<TypeDefinition> GetDocumentationTypes (AssemblyDefinition
continue;
if (seen != null && seen.Contains (type.FullName))
continue;
yield return type;
yield return DocUtils.FixUnnamedParameters (type);
}
}

Expand Down
10 changes: 5 additions & 5 deletions mdoc/Test/en.expected-fsharp/AbstractClasses+Shape2D.xml
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,9 @@
</Docs>
</Member>
<Member MemberName="Rotate2">
<MemberSignature Language="C#" Value="public abstract void Rotate2 (double );" />
<MemberSignature Language="ILAsm" Value=".method public hidebysig virtual instance void Rotate2(float64 ) cil managed" />
<MemberSignature Language="F#" Value="abstract member Rotate2 : double -&gt; unit" Usage="shape2D.Rotate2 " />
<MemberSignature Language="C#" Value="public abstract void Rotate2 (double unnamedParam1);" />
<MemberSignature Language="ILAsm" Value=".method public hidebysig virtual instance void Rotate2(float64 unnamedParam1) cil managed" />
<MemberSignature Language="F#" Value="abstract member Rotate2 : double -&gt; unit" Usage="shape2D.Rotate2 unnamedParam1" />
<MemberType>Method</MemberType>
<AssemblyInfo>
<AssemblyVersion>1.0.0.0</AssemblyVersion>
Expand All @@ -142,10 +142,10 @@
<ReturnType>System.Void</ReturnType>
</ReturnValue>
<Parameters>
<Parameter Name="" Type="System.Double" />
<Parameter Name="unnamedParam1" Type="System.Double" />
</Parameters>
<Docs>
<param name="">To be added.</param>
<param name="unnamedParam1">To be added.</param>
<summary>To be added.</summary>
<remarks>To be added.</remarks>
</Docs>
Expand Down
6 changes: 3 additions & 3 deletions mdoc/Test/en.expected-fsharp/Delegates+Delegate1.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<Type Name="Delegates+Delegate1" FullName="Delegates+Delegate1">
<TypeSignature Language="C#" Value="public delegate int Delegates.Delegate1(Tuple&lt;int,int&gt; );" />
<TypeSignature Language="C#" Value="public delegate int Delegates.Delegate1(Tuple&lt;int,int&gt; unnamedParam1);" />
<TypeSignature Language="ILAsm" Value=".class nested public auto ansi serializable sealed Delegates/Delegate1 extends System.MulticastDelegate" />
<TypeSignature Language="F#" Value="type Delegates.Delegate1 = delegate of (int * int) -&gt; int" />
<AssemblyInfo>
Expand All @@ -20,13 +20,13 @@
</Attribute>
</Attributes>
<Parameters>
<Parameter Name="" Type="System.Tuple&lt;System.Int32,System.Int32&gt;" />
<Parameter Name="unnamedParam1" Type="System.Tuple&lt;System.Int32,System.Int32&gt;" />
</Parameters>
<ReturnValue>
<ReturnType>System.Int32</ReturnType>
</ReturnValue>
<Docs>
<param name="">To be added.</param>
<param name="unnamedParam1">To be added.</param>
<summary>To be added.</summary>
<returns>To be added.</returns>
<remarks>To be added.</remarks>
Expand Down
10 changes: 5 additions & 5 deletions mdoc/Test/en.expected-fsharp/Delegates+Delegate10.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<Type Name="Delegates+Delegate10" FullName="Delegates+Delegate10">
<TypeSignature Language="C#" Value="public delegate char Delegates.Delegate10(int , int );" />
<TypeSignature Language="C#" Value="public delegate char Delegates.Delegate10(int unnamedParam1, int unnamedParam2);" />
<TypeSignature Language="ILAsm" Value=".class nested public auto ansi serializable sealed Delegates/Delegate10 extends System.MulticastDelegate" />
<TypeSignature Language="F#" Value="type Delegates.Delegate10 = delegate of int * int -&gt; char" />
<AssemblyInfo>
Expand All @@ -20,15 +20,15 @@
</Attribute>
</Attributes>
<Parameters>
<Parameter Name="" Type="System.Int32" />
<Parameter Name="" Type="System.Int32" />
<Parameter Name="unnamedParam1" Type="System.Int32" />
<Parameter Name="unnamedParam2" Type="System.Int32" />
</Parameters>
<ReturnValue>
<ReturnType>System.Char</ReturnType>
</ReturnValue>
<Docs>
<param name="">To be added.</param>
<param name="">To be added.</param>
<param name="unnamedParam1">To be added.</param>
<param name="unnamedParam2">To be added.</param>
<summary>To be added.</summary>
<returns>To be added.</returns>
<remarks>To be added.</remarks>
Expand Down
6 changes: 3 additions & 3 deletions mdoc/Test/en.expected-fsharp/Delegates+Delegate11.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<Type Name="Delegates+Delegate11" FullName="Delegates+Delegate11">
<TypeSignature Language="C#" Value="public delegate void Delegates.Delegate11(char );" />
<TypeSignature Language="C#" Value="public delegate void Delegates.Delegate11(char unnamedParam1);" />
<TypeSignature Language="ILAsm" Value=".class nested public auto ansi serializable sealed Delegates/Delegate11 extends System.MulticastDelegate" />
<TypeSignature Language="F#" Value="type Delegates.Delegate11 = delegate of char -&gt; unit" />
<AssemblyInfo>
Expand All @@ -20,13 +20,13 @@
</Attribute>
</Attributes>
<Parameters>
<Parameter Name="" Type="System.Char" />
<Parameter Name="unnamedParam1" Type="System.Char" />
</Parameters>
<ReturnValue>
<ReturnType>System.Void</ReturnType>
</ReturnValue>
<Docs>
<param name="">To be added.</param>
<param name="unnamedParam1">To be added.</param>
<summary>To be added.</summary>
<remarks>To be added.</remarks>
</Docs>
Expand Down
6 changes: 3 additions & 3 deletions mdoc/Test/en.expected-fsharp/Delegates+Delegate13.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<Type Name="Delegates+Delegate13" FullName="Delegates+Delegate13">
<TypeSignature Language="C#" Value="public delegate double Delegates.Delegate13(FSharpFunc&lt;int,FSharpFunc&lt;char,FSharpFunc&lt;string,decimal&gt;&gt;&gt; );" />
<TypeSignature Language="C#" Value="public delegate double Delegates.Delegate13(FSharpFunc&lt;int,FSharpFunc&lt;char,FSharpFunc&lt;string,decimal&gt;&gt;&gt; unnamedParam1);" />
<TypeSignature Language="ILAsm" Value=".class nested public auto ansi serializable sealed Delegates/Delegate13 extends System.MulticastDelegate" />
<TypeSignature Language="F#" Value="type Delegates.Delegate13 = delegate of (int -&gt; char -&gt; string -&gt; decimal) -&gt; double" />
<AssemblyInfo>
Expand All @@ -20,13 +20,13 @@
</Attribute>
</Attributes>
<Parameters>
<Parameter Name="" Type="Microsoft.FSharp.Core.FSharpFunc&lt;System.Int32,Microsoft.FSharp.Core.FSharpFunc&lt;System.Char,Microsoft.FSharp.Core.FSharpFunc&lt;System.String,System.Decimal&gt;&gt;&gt;" />
<Parameter Name="unnamedParam1" Type="Microsoft.FSharp.Core.FSharpFunc&lt;System.Int32,Microsoft.FSharp.Core.FSharpFunc&lt;System.Char,Microsoft.FSharp.Core.FSharpFunc&lt;System.String,System.Decimal&gt;&gt;&gt;" />
</Parameters>
<ReturnValue>
<ReturnType>System.Double</ReturnType>
</ReturnValue>
<Docs>
<param name="">To be added.</param>
<param name="unnamedParam1">To be added.</param>
<summary>To be added.</summary>
<returns>To be added.</returns>
<remarks>To be added.</remarks>
Expand Down
10 changes: 5 additions & 5 deletions mdoc/Test/en.expected-fsharp/Delegates+Delegate2.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<Type Name="Delegates+Delegate2" FullName="Delegates+Delegate2">
<TypeSignature Language="C#" Value="public delegate int Delegates.Delegate2(int , int );" />
<TypeSignature Language="C#" Value="public delegate int Delegates.Delegate2(int unnamedParam1, int unnamedParam2);" />
<TypeSignature Language="ILAsm" Value=".class nested public auto ansi serializable sealed Delegates/Delegate2 extends System.MulticastDelegate" />
<TypeSignature Language="F#" Value="type Delegates.Delegate2 = delegate of int * int -&gt; int" />
<AssemblyInfo>
Expand All @@ -20,15 +20,15 @@
</Attribute>
</Attributes>
<Parameters>
<Parameter Name="" Type="System.Int32" />
<Parameter Name="" Type="System.Int32" />
<Parameter Name="unnamedParam1" Type="System.Int32" />
<Parameter Name="unnamedParam2" Type="System.Int32" />
</Parameters>
<ReturnValue>
<ReturnType>System.Int32</ReturnType>
</ReturnValue>
<Docs>
<param name="">To be added.</param>
<param name="">To be added.</param>
<param name="unnamedParam1">To be added.</param>
<param name="unnamedParam2">To be added.</param>
<summary>To be added.</summary>
<returns>To be added.</returns>
<remarks>To be added.</remarks>
Expand Down
10 changes: 5 additions & 5 deletions mdoc/Test/en.expected-fsharp/Delegates+Delegate3.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<Type Name="Delegates+Delegate3" FullName="Delegates+Delegate3">
<TypeSignature Language="C#" Value="public delegate string Delegates.Delegate3(int , char );" />
<TypeSignature Language="C#" Value="public delegate string Delegates.Delegate3(int unnamedParam1, char unnamedParam2);" />
<TypeSignature Language="ILAsm" Value=".class nested public auto ansi serializable sealed Delegates/Delegate3 extends System.MulticastDelegate" />
<TypeSignature Language="F#" Value="type Delegates.Delegate3 = delegate of int * char -&gt; string" />
<AssemblyInfo>
Expand All @@ -20,15 +20,15 @@
</Attribute>
</Attributes>
<Parameters>
<Parameter Name="" Type="System.Int32" />
<Parameter Name="" Type="System.Char" />
<Parameter Name="unnamedParam1" Type="System.Int32" />
<Parameter Name="unnamedParam2" Type="System.Char" />
</Parameters>
<ReturnValue>
<ReturnType>System.String</ReturnType>
</ReturnValue>
<Docs>
<param name="">To be added.</param>
<param name="">To be added.</param>
<param name="unnamedParam1">To be added.</param>
<param name="unnamedParam2">To be added.</param>
<summary>To be added.</summary>
<returns>To be added.</returns>
<remarks>To be added.</remarks>
Expand Down
6 changes: 3 additions & 3 deletions mdoc/Test/en.expected-fsharp/Delegates+Delegate4.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<Type Name="Delegates+Delegate4" FullName="Delegates+Delegate4">
<TypeSignature Language="C#" Value="public delegate Microsoft.FSharp.Core.FSharpFunc&lt;int,char&gt; Delegates.Delegate4(int );" />
<TypeSignature Language="C#" Value="public delegate Microsoft.FSharp.Core.FSharpFunc&lt;int,char&gt; Delegates.Delegate4(int unnamedParam1);" />
<TypeSignature Language="ILAsm" Value=".class nested public auto ansi serializable sealed Delegates/Delegate4 extends System.MulticastDelegate" />
<TypeSignature Language="F#" Value="type Delegates.Delegate4 = delegate of int -&gt; (int -&gt; char)" />
<AssemblyInfo>
Expand All @@ -20,13 +20,13 @@
</Attribute>
</Attributes>
<Parameters>
<Parameter Name="" Type="System.Int32" />
<Parameter Name="unnamedParam1" Type="System.Int32" />
</Parameters>
<ReturnValue>
<ReturnType>Microsoft.FSharp.Core.FSharpFunc&lt;System.Int32,System.Char&gt;</ReturnType>
</ReturnValue>
<Docs>
<param name="">To be added.</param>
<param name="unnamedParam1">To be added.</param>
<summary>To be added.</summary>
<returns>To be added.</returns>
<remarks>To be added.</remarks>
Expand Down
6 changes: 3 additions & 3 deletions mdoc/Test/en.expected-fsharp/Delegates+Delegate5.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<Type Name="Delegates+Delegate5" FullName="Delegates+Delegate5">
<TypeSignature Language="C#" Value="public delegate Microsoft.FSharp.Core.FSharpFunc&lt;int,Microsoft.FSharp.Core.FSharpFunc&lt;char,string&gt;&gt; Delegates.Delegate5(int );" />
<TypeSignature Language="C#" Value="public delegate Microsoft.FSharp.Core.FSharpFunc&lt;int,Microsoft.FSharp.Core.FSharpFunc&lt;char,string&gt;&gt; Delegates.Delegate5(int unnamedParam1);" />
<TypeSignature Language="ILAsm" Value=".class nested public auto ansi serializable sealed Delegates/Delegate5 extends System.MulticastDelegate" />
<TypeSignature Language="F#" Value="type Delegates.Delegate5 = delegate of int -&gt; (int -&gt; char -&gt; string)" />
<AssemblyInfo>
Expand All @@ -20,13 +20,13 @@
</Attribute>
</Attributes>
<Parameters>
<Parameter Name="" Type="System.Int32" />
<Parameter Name="unnamedParam1" Type="System.Int32" />
</Parameters>
<ReturnValue>
<ReturnType>Microsoft.FSharp.Core.FSharpFunc&lt;System.Int32,Microsoft.FSharp.Core.FSharpFunc&lt;System.Char,System.String&gt;&gt;</ReturnType>
</ReturnValue>
<Docs>
<param name="">To be added.</param>
<param name="unnamedParam1">To be added.</param>
<summary>To be added.</summary>
<returns>To be added.</returns>
<remarks>To be added.</remarks>
Expand Down
6 changes: 3 additions & 3 deletions mdoc/Test/en.expected-fsharp/Delegates+Delegate6.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<Type Name="Delegates+Delegate6" FullName="Delegates+Delegate6">
<TypeSignature Language="C#" Value="public delegate char Delegates.Delegate6(FSharpFunc&lt;int,double&gt; );" />
<TypeSignature Language="C#" Value="public delegate char Delegates.Delegate6(FSharpFunc&lt;int,double&gt; unnamedParam1);" />
<TypeSignature Language="ILAsm" Value=".class nested public auto ansi serializable sealed Delegates/Delegate6 extends System.MulticastDelegate" />
<TypeSignature Language="F#" Value="type Delegates.Delegate6 = delegate of (int -&gt; double) -&gt; char" />
<AssemblyInfo>
Expand All @@ -20,13 +20,13 @@
</Attribute>
</Attributes>
<Parameters>
<Parameter Name="" Type="Microsoft.FSharp.Core.FSharpFunc&lt;System.Int32,System.Double&gt;" />
<Parameter Name="unnamedParam1" Type="Microsoft.FSharp.Core.FSharpFunc&lt;System.Int32,System.Double&gt;" />
</Parameters>
<ReturnValue>
<ReturnType>System.Char</ReturnType>
</ReturnValue>
<Docs>
<param name="">To be added.</param>
<param name="unnamedParam1">To be added.</param>
<summary>To be added.</summary>
<returns>To be added.</returns>
<remarks>To be added.</remarks>
Expand Down
6 changes: 3 additions & 3 deletions mdoc/Test/en.expected-fsharp/Delegates+Delegate7.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<Type Name="Delegates+Delegate7" FullName="Delegates+Delegate7">
<TypeSignature Language="C#" Value="public delegate double Delegates.Delegate7(FSharpFunc&lt;int,FSharpFunc&lt;char,string&gt;&gt; );" />
<TypeSignature Language="C#" Value="public delegate double Delegates.Delegate7(FSharpFunc&lt;int,FSharpFunc&lt;char,string&gt;&gt; unnamedParam1);" />
<TypeSignature Language="ILAsm" Value=".class nested public auto ansi serializable sealed Delegates/Delegate7 extends System.MulticastDelegate" />
<TypeSignature Language="F#" Value="type Delegates.Delegate7 = delegate of (int -&gt; char -&gt; string) -&gt; double" />
<AssemblyInfo>
Expand All @@ -20,13 +20,13 @@
</Attribute>
</Attributes>
<Parameters>
<Parameter Name="" Type="Microsoft.FSharp.Core.FSharpFunc&lt;System.Int32,Microsoft.FSharp.Core.FSharpFunc&lt;System.Char,System.String&gt;&gt;" />
<Parameter Name="unnamedParam1" Type="Microsoft.FSharp.Core.FSharpFunc&lt;System.Int32,Microsoft.FSharp.Core.FSharpFunc&lt;System.Char,System.String&gt;&gt;" />
</Parameters>
<ReturnValue>
<ReturnType>System.Double</ReturnType>
</ReturnValue>
<Docs>
<param name="">To be added.</param>
<param name="unnamedParam1">To be added.</param>
<summary>To be added.</summary>
<returns>To be added.</returns>
<remarks>To be added.</remarks>
Expand Down
6 changes: 3 additions & 3 deletions mdoc/Test/en.expected-fsharp/Delegates+Delegate8.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<Type Name="Delegates+Delegate8" FullName="Delegates+Delegate8">
<TypeSignature Language="C#" Value="public delegate char Delegates.Delegate8(int );" />
<TypeSignature Language="C#" Value="public delegate char Delegates.Delegate8(int unnamedParam1);" />
<TypeSignature Language="ILAsm" Value=".class nested public auto ansi serializable sealed Delegates/Delegate8 extends System.MulticastDelegate" />
<TypeSignature Language="F#" Value="type Delegates.Delegate8 = delegate of int -&gt; char" />
<AssemblyInfo>
Expand All @@ -20,13 +20,13 @@
</Attribute>
</Attributes>
<Parameters>
<Parameter Name="" Type="System.Int32" />
<Parameter Name="unnamedParam1" Type="System.Int32" />
</Parameters>
<ReturnValue>
<ReturnType>System.Char</ReturnType>
</ReturnValue>
<Docs>
<param name="">To be added.</param>
<param name="unnamedParam1">To be added.</param>
<summary>To be added.</summary>
<returns>To be added.</returns>
<remarks>To be added.</remarks>
Expand Down
6 changes: 3 additions & 3 deletions mdoc/Test/en.expected-fsharp/Delegates+Delegate9.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<Type Name="Delegates+Delegate9" FullName="Delegates+Delegate9">
<TypeSignature Language="C#" Value="public delegate char Delegates.Delegate9(Tuple&lt;int,int&gt; );" />
<TypeSignature Language="C#" Value="public delegate char Delegates.Delegate9(Tuple&lt;int,int&gt; unnamedParam1);" />
<TypeSignature Language="ILAsm" Value=".class nested public auto ansi serializable sealed Delegates/Delegate9 extends System.MulticastDelegate" />
<TypeSignature Language="F#" Value="type Delegates.Delegate9 = delegate of (int * int) -&gt; char" />
<AssemblyInfo>
Expand All @@ -20,13 +20,13 @@
</Attribute>
</Attributes>
<Parameters>
<Parameter Name="" Type="System.Tuple&lt;System.Int32,System.Int32&gt;" />
<Parameter Name="unnamedParam1" Type="System.Tuple&lt;System.Int32,System.Int32&gt;" />
</Parameters>
<ReturnValue>
<ReturnType>System.Char</ReturnType>
</ReturnValue>
<Docs>
<param name="">To be added.</param>
<param name="unnamedParam1">To be added.</param>
<summary>To be added.</summary>
<returns>To be added.</returns>
<remarks>To be added.</remarks>
Expand Down
10 changes: 5 additions & 5 deletions mdoc/Test/en.expected-fsharp/Interfaces+Interface0.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@
</Docs>
<Members>
<Member MemberName="Method1">
<MemberSignature Language="C#" Value="public int Method1 (int );" />
<MemberSignature Language="ILAsm" Value=".method public hidebysig virtual instance int32 Method1(int32 ) cil managed" />
<MemberSignature Language="F#" Value="abstract member Method1 : int -&gt; int" Usage="interface0.Method1 " />
<MemberSignature Language="C#" Value="public int Method1 (int unnamedParam1);" />
<MemberSignature Language="ILAsm" Value=".method public hidebysig virtual instance int32 Method1(int32 unnamedParam1) cil managed" />
<MemberSignature Language="F#" Value="abstract member Method1 : int -&gt; int" Usage="interface0.Method1 unnamedParam1" />
<MemberType>Method</MemberType>
<AssemblyInfo>
<AssemblyVersion>1.0.0.0</AssemblyVersion>
Expand All @@ -34,10 +34,10 @@
<ReturnType>System.Int32</ReturnType>
</ReturnValue>
<Parameters>
<Parameter Name="" Type="System.Int32" />
<Parameter Name="unnamedParam1" Type="System.Int32" />
</Parameters>
<Docs>
<param name="">To be added.</param>
<param name="unnamedParam1">To be added.</param>
<summary>To be added.</summary>
<returns>To be added.</returns>
<remarks>To be added.</remarks>
Expand Down
10 changes: 5 additions & 5 deletions mdoc/Test/en.expected-fsharp/Interfaces+Interface1.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@
</Docs>
<Members>
<Member MemberName="Method1">
<MemberSignature Language="C#" Value="public int Method1 (int );" />
<MemberSignature Language="ILAsm" Value=".method public hidebysig virtual instance int32 Method1(int32 ) cil managed" />
<MemberSignature Language="F#" Value="abstract member Method1 : int -&gt; int" Usage="interface1.Method1 " />
<MemberSignature Language="C#" Value="public int Method1 (int unnamedParam1);" />
<MemberSignature Language="ILAsm" Value=".method public hidebysig virtual instance int32 Method1(int32 unnamedParam1) cil managed" />
<MemberSignature Language="F#" Value="abstract member Method1 : int -&gt; int" Usage="interface1.Method1 unnamedParam1" />
<MemberType>Method</MemberType>
<AssemblyInfo>
<AssemblyVersion>1.0.0.0</AssemblyVersion>
Expand All @@ -34,10 +34,10 @@
<ReturnType>System.Int32</ReturnType>
</ReturnValue>
<Parameters>
<Parameter Name="" Type="System.Int32" />
<Parameter Name="unnamedParam1" Type="System.Int32" />
</Parameters>
<Docs>
<param name="">To be added.</param>
<param name="unnamedParam1">To be added.</param>
<summary>To be added.</summary>
<returns>To be added.</returns>
<remarks>To be added.</remarks>
Expand Down
Loading