Skip to content

Conversation

@joelmartinez
Copy link
Member

No description provided.

@joelmartinez joelmartinez changed the base branch from master to develop January 22, 2021 22:07
… Add .NET Core platform assemblies from the installation path of the .NET Core by the custom DefaultAssemblyResolver for WSL, macOS, and Ubuntu OS environment.
@hiihellox10
Copy link
Contributor

@joelmartinez the return type issue is fixed.

Copy link
Member Author

@joelmartinez joelmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hiihellox10 These changes look good, but one small change please ... we generally try to be as permissive with mdoc's running parameters, to avoid hard stops for system configuration issues; opting instead to be verbose in the log with what issues are found.

@joelmartinez joelmartinez merged commit 30de437 into develop Feb 24, 2021
@joelmartinez joelmartinez deleted the marj/mdoc-5.8.1 branch February 24, 2021 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants