[.NET] Compound Type Constraint Does Not Render #545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hecked. Add a new if statement to check for isnew after the constraints are checked.
Collaborator
|
@michaeljin89757 please check the integration error and fix it. |
Contributor
|
You should write a test case to reproduce the issue and fix it. |
michaeljin89757
changed the title
added 2 commits
April 14, 2021 13:43
2. Append new condition to add comma when there is constraint.
|
|
added 23 commits
April 15, 2021 15:32
joelmartinez
requested changes
Apr 19, 2021
Member
joelmartinez
left a comment
joelmartinez
left a comment
There was a problem hiding this comment.
Thanks for this contribution. There's a few items of feedback ... and then a small reminder that when you add the new test method, you'll have to again change the expected XMLs to reflect this new item.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new if statement to check for isnew after the constraints are checked.