Added type forwarding check #548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
MicrosoftDocs/azure-docs-sdk-dotnet@master...jeffreyxrh:jex/373824 diff report generated 20210416 |
joelmartinez
requested changes
Apr 19, 2021
| else | ||
| { | ||
| var assemblies = this.assemblies.Where(a => a.Name == typeEntry.Framework.Name).ToList(); | ||
| return assemblies.Any(a => a.IsTypeForwardingTo(typeEntry)); |
Member
There was a problem hiding this comment.
There are two similar but independent scenarios that this fix should be addressing:
- A type forward assembly + the assembly with the actual definition
- Two separate assemblies, with the same type (name), but different
TypeDefinitions (ie. different members ... such as different extension methods depending on which assembly reference you've added).
I would like to see some integration tests that reflect both of these scenarios. In fact, there's already a type forward test included here ... maybe you could add to that particular test, a separate test class that reflects the second scenario, to make sure that mdoc will correctly add all methods in both classes.
Suggested change
| return assemblies.Any(a => a.IsTypeForwardingTo(typeEntry)); | |
| return assemblies.Any(a => a.IsTypeForwardingTo(typeEntry)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dev.azure.com/ceapex/Engineering/_workitems/edit/373824