[MDocUpdater] Fix assembly info duplication #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pjcollins please target to |
The `AssemblyPublicKey` and `AssemblyCulture` elements will be added to to a docs `index.xml` file every time the tool runs, even if the element already exists. Fix this by using `MDocUpdater.WriteElement` to write these elements, as it will first check for an existing element rather than always creating a new one.
pjcollins
force-pushed
the
dupe-assembly-attribs
branch
from
1a20419 to
e8511f5
Compare
huangmin-ms
approved these changes
Jul 14, 2022
jonpryor
pushed a commit
to dotnet/android
that referenced
this pull request
Jul 18, 2022
Context: mono/api-doc-tools@039a030 Context: mono/api-doc-tools#638 Changes: mono/api-doc-tools@mdoc-5.8.5...mdoc-5.8.9.2 Updates [mdoc][0] to the latest release, and add a parameter to `azure-pipelines-apidocs.yaml` to allow any version of mdoc to be used when generating docs. [0]: https://www.nuget.org/packages/mdoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
AssemblyPublicKeyandAssemblyCultureelements will be added toto a docs
index.xmlfile every time the tool runs, even if the elementalready exists. Fix this by using
MDocUpdater.WriteElementto writethese elements, as it will first check for an existing element rather
than always creating a new one.