This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
[Gendarme] New Security rule: SqlCommandShouldUseNamedParameters #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I do not recall |
|
Oh, you're right, TestCase() is only available in NUnit 2.5 or newer, and in Mono's NUnit (2.4.8) it errors out with: test.cs(11,4): error CS0616: `NUnit.Framework.TestCase': is not an attribute class So I'll change the PR to not use it. |
This rule will report failures on source code prone to SQL injection attacks. It includes basic tests that cover SqlCommand usage via constructor and CommandText property. Contributed under the MIT/X11 licence.
I don't work for Novell anymore
|
Fixed! |
|
ping :) |
|
@spouliot ping |
|
ping... |
|
how to get the rule, i can not find the rule in source code. |
|
@rosslight it has not been merged yet, you can extract the patch from here and apply it manually: https://github.com/mono/mono-tools/pull/32/files |
|
@knocte thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule will report failures on source code prone to SQL injection
attacks.
It includes basic tests that cover SqlCommand usage via
constructor and CommandText property.
Contributed under the MIT/X11 licence.