-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Threading issues with Mono 5.18 and later #11168
Comments
Thanks @lemonmojo! I see This is most likely a duplicate of #11138. |
@lambdageek Yeah, could be the same issue. In Royal TSX I'm using a custom fork of Monobjc which also uses icalls extensively and I'm seeing issues all over the place. The only one that's consitently reproducible is the WebKit issue though. Would you let me know once a potential fix is ready to be tested? |
@lambdageek Just wanted to let you know that the workaround of setting |
@lemonmojo yea, rolling back to the old suspend mechanism is an option. |
Closing as duplicate of #11168. @lemonmojo please reopen if you can still reproduce the issue |
@marek-safar I guess you're referring to #11138, right? |
@lemonmojo installing a new build should be enough. If you still get hangs, please reopen. One thing that would be particularly useful if you're still having problems is if you could run with |
@lambdageek Looks good so far. I quickly tested AOT and my app crashed with the following trace:
I'm not currently using AOT so I didn't investigate any further but you might want to check if there are additional fixes needed for AOT on the Mac. |
@lemonmojo Thanks! that looks similar to #11403 - I'll keep an eye for it. FYI, we decided to revert back to preemptive suspend (instead of hybrid suspend) for 5.18 - we'll keep working on hybrid suspend in 5.20 and later. So if you install 5.18.0.185 or later, it'll go back to preemptive suspend ( |
@lambdageek That's interesting. I actually installed a build from the 2010-10 branch (Mono version 5.20.0.65) and sure enough |
@lambdageek So I cannot reproduce the threading issue with 5.18.0.185 which is to be expected as you mentioned you rolled back to the old suspend method. I still have issues with AOT though. When AOTing with 5.18.0.185 the crash trace is a little different:
Are ICALLs supported at all under AOT? |
@lemonmojo mind opening a new GH Issue for the AOT icall thing? try running with |
Mono version 5.18 and later (currently using 5.20.0.24) seem to have threading issues on macOS 10.14. I've encountered multiple freezes/hangs, seemingly out of nowhere. The trace for one of them is attached below. The only thing I did to cause this was to start VS for Mac.
I already mentioned in another thread (#10802 (comment)) that it seems to be related to WebKit somehow as I can reliably reproduce the issue when invoking a completion handler of a WebKit delegate method. If you look carefully at the trace below, you'll also find a reference to WebKit (
WebCore::ImageSource::frameDurationAtIndex(unsigned long)
).Steps to Reproduce
Current Behavior
The app hangs randomly.
Expected Behavior
Shouldn't hang.
On which platforms did you notice this
[x] macOS
[ ] Linux
[ ] Windows
Version Used:
Mono JIT compiler version 5.20.0.24 (2018-10/d33c2133545 Thu Oct 11 17:13:47 EDT 2018)
Stacktrace
The text was updated successfully, but these errors were encountered: