This repository was archived by the owner on Oct 4, 2021. It is now read-only.
Add GetDefaultConfiguration behaviour #1196
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hach-que
force-pushed
the
roslyn-defaultconfig
branch
from
cc6ff22 to
8ea3a78
Compare
| @@ -315,6 +315,15 @@ void SelectActiveConfiguration () | |||
| var confs = ToolbarView.ConfigurationModel.ToList (); | |||
| if (confs.Count > 0) { | |||
| string defaultConfig = ToolbarView.ActiveConfiguration != null ? ToolbarView.ActiveConfiguration.OriginalId : confs[0].OriginalId; | |||
|
|
|||
| foreach (Solution sol in IdeApp.Workspace.GetAllSolutions()) { | |||
There was a problem hiding this comment.
This second call is necessary (in addition to GetBestDefaultConfiguration) because this is called when the solution is first loaded, while GetBestDefaultConfiguration is not. They trigger under different scenarios, so adding the logic in both places is required.
There was a problem hiding this comment.
AFAICT GetBestDefaultConfiguration is always called, event when the solution is first loaded. In which case it isn't called?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #1157 targeting the master branch instead.
In Protobuild, we use project configurations as targetable platforms, instead of Debug / Release. This is because there's no way for an add-in to add more drop-down menus to the toolbar.
By default MonoDevelop picks the first entry in the configuration in the list when opening a solution, which for Protobuild projects will be Android (because it's alphabetically sorted). However, we actually want to default the configuration to the current host platform.
This adds a virtual method that allows MonoDevelop to query the current solutions to see if they have a preferred default configuration.