[Addin] To allow CBinding to use "Project" property #2870

gitexperience · 2017-08-05T21:17:44Z

CMakeProject being derived from SolutionItem is unable to access the "Project" property. The PR is intended to test the changes needed to make the "Project" property available to the CBinding's CMakeProject.

monojenkins · 2017-08-05T21:17:45Z

Hello! I'm the build bot for the Mono project.

I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Additional trigger words are available here.

Contributors can ignore this message.

mhutch

Almost there! Just a few changes for consistency and backwards-compatibility.

mhutch · 2017-08-07T17:23:58Z

main/src/addins/MonoDevelop.ConnectedServices/Gui.ServicesTab/ConnectedServicesWidget.cs

@@ -56,7 +56,7 @@ public ConnectedServicesWidget ()
 		/// <summary>
 		/// Shows the services gallery and removes the details widget if it is visible
 		/// </summary>
-		public void ShowGallery(IConnectedService[] services, Project project)
+		public void ShowGallery(IConnectedService[] services, SolutionItem owner)


Add an overload that takes a Project and calls the SolutionItem version, so that the public API doesn't change.

mhutch · 2017-08-07T17:25:03Z

main/src/addins/MonoDevelop.DesignerSupport/MonoDevelop.DesignerSupport/WrapperDesignView.cs

@@ -88,6 +88,12 @@ protected override void OnSetProject (MonoDevelop.Projects.Project project)
 			content.Project = project;


You should be able to remove the OnSetProject as it's handled by OnSetOwner.

mhutch · 2017-08-07T17:25:06Z

main/src/addins/MonoDevelop.GtkCore/MonoDevelop.GtkCore.GuiBuilder/CombinedDesignView.cs

@@ -115,6 +115,12 @@ protected override void OnSetProject (Projects.Project project)
 			content.Project = project; 


You should be able to remove the OnSetProject as it's handled by OnSetOwner.

mhutch · 2017-08-07T17:25:46Z

main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.GettingStarted/GettingStarted.cs

@@ -38,9 +38,9 @@ public static GettingStartedProvider GetGettingStartedProvider (this Project pro
 			return null;
 		}

-		public static GettingStartedNode GetGettingStartedNode (this Project project)
+		public static GettingStartedNode GetGettingStartedNode (this SolutionItem owner)


Add a Project overload that chains to SolutionItem.

mhutch · 2017-08-07T17:26:50Z

main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui/BaseViewContent.cs

@@ -142,6 +143,20 @@ internal protected virtual void OnDeselected ()
 		protected virtual void OnSetProject (Project project)


This can be [Obsoleted]; subclasses should override Owner instead.

Also, the Project property should chain to Owner, i.e.

public Project Project { get { return Owner as Project; } set { OnSetOwner(project); } }

mhutch · 2017-08-07T17:29:41Z

main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui/BaseViewContent.cs

+
+		protected virtual void OnSetOwner (SolutionItem owner)
+		{
+			this.owner = owner;


This should also call OnSetProject() if the owner is a project.

if (owner is Project project) { OnSetProject(project); }

mhutch · 2017-08-07T17:30:31Z

main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.TypeSystem/TypeSystemParser.cs

@@ -55,6 +55,7 @@ public sealed class ParseOptions
 		public ITextSource Content { get; set; }

 		public MonoDevelop.Projects.Project Project { get; set; }


This should also forward to Owner.

slluis · 2017-08-08T08:33:38Z

main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui/ViewContent.cs

@@ -92,7 +92,7 @@ public abstract class ViewContent : BaseViewContent
 		public virtual object GetDocumentObject ()
 		{
 			string path = IsUntitled ? UntitledName : ContentName;
-			if (IsFile && !string.IsNullOrEmpty (path) && Project != null) {
+			if (IsFile && !string.IsNullOrEmpty (path) && Owner != null) {


This should not be changed, since we use the Project property just below, so Project must be != null.

slluis · 2017-08-08T08:46:11Z

It looks good overall!

gitexperience · 2017-08-13T08:36:11Z

main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui/Workbench.cs

@@ -524,6 +533,18 @@ internal Task<Document> OpenDocument (FilePath fileName, Project project, int li
 			return OpenDocument (openFileInfo);
 		}

+		internal Task<Document> OpenDocument (FilePath fileName, SolutionItem owner, int line, int column, OpenDocumentOptions options, Encoding encoding, IViewDisplayBinding binding)
+		{
+			var openFileInfo = new FileOpenInformation (fileName, owner as Project) {


@mhutch , here owner can only ever be Project .Is it ok to do so ? Or do we need to create all the referred methods for SolutionItem as well ?

It needs to be propagated...

If you follow the logic -

RealOpenFile reads the Project from the FileOpenInformation

monodevelop/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui/Workbench.cs

Line 972 in bba532b

Project project = openFileInfo.Project ?? GetProjectContainingFile (fileName);

The project gets passed to LoadFileWrapper

monodevelop/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui/Workbench.cs

Line 996 in bba532b

var fw = new LoadFileWrapper (monitor, workbench, viewBinding, project, openFileInfo);

it's used to set the Project on the ViewContent:

monodevelop/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui/Workbench.cs

Line 1583 in bba532b

newContent.Project = project;

I would suggest adding an Owner property to FileOpenInformation and having FileOpenInformation.Project forward to that, just like the other owner/project forwarding pairs.

Then RealOpenFile and LoadFileWrapper can use the FileOpenInformation.Owner instead of the project, and sent the Owner on the ViewContent.

Fortunately RealOpenFile and LoadFileWrapper are not public so do not have to keep API compatibility.

mhutch · 2017-08-11T21:28:16Z

main/external/fsharpbinding/MonoDevelop.FSharp.Tests/TestDocument.fs

@@ -9,6 +9,7 @@ type TestDocument(name, parsedDocument, editor: TextEditor) =

        override x.Name = name
        override x.Project = null


setting Project is unnecessary here as it's forwarded from Owner

mhutch · 2017-08-14T19:16:59Z

main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui/Workbench.cs

@@ -524,6 +533,18 @@ internal Task<Document> OpenDocument (FilePath fileName, Project project, int li
 			return OpenDocument (openFileInfo);
 		}

+		internal Task<Document> OpenDocument (FilePath fileName, SolutionItem owner, int line, int column, OpenDocumentOptions options, Encoding encoding, IViewDisplayBinding binding)
+		{
+			var openFileInfo = new FileOpenInformation (fileName, owner as Project) {


It needs to be propagated...

If you follow the logic -

RealOpenFile reads the Project from the FileOpenInformation

monodevelop/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui/Workbench.cs

Line 972 in bba532b

Project project = openFileInfo.Project ?? GetProjectContainingFile (fileName);

The project gets passed to LoadFileWrapper

monodevelop/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui/Workbench.cs

Line 996 in bba532b

var fw = new LoadFileWrapper (monitor, workbench, viewBinding, project, openFileInfo);

it's used to set the Project on the ViewContent:

monodevelop/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui/Workbench.cs

Line 1583 in bba532b

newContent.Project = project;

I would suggest adding an Owner property to FileOpenInformation and having FileOpenInformation.Project forward to that, just like the other owner/project forwarding pairs.

Then RealOpenFile and LoadFileWrapper can use the FileOpenInformation.Owner instead of the project, and sent the Owner on the ViewContent.

Fortunately RealOpenFile and LoadFileWrapper are not public so do not have to keep API compatibility.

mhutch

Couple small changes but otherwise looking good

mhutch · 2017-08-15T22:32:49Z

main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui/Workbench.cs

-							if (info.Project != null && doc.Project != info.Project) {
-								doc.SetProject (info.Project);
+							if (info.Owner != null && doc.Owner != info.Owner) {
+								doc.SetProject (info.Owner as Project);


This should be SetOwner :)

mhutch · 2017-08-15T22:37:09Z

main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui/Workbench.cs

 						app.Launch (fileName);
 					}

 					Counters.OpenDocumentTimer.Trace ("Adding to recent files");
-					DesktopService.RecentFiles.AddFile (fileName, project);
+					DesktopService.RecentFiles.AddFile (fileName, owner as Project);


RecentFiles.Add could also have a SolutionItem owner overload.

mhutch · 2017-08-15T22:45:28Z

main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui/Workbench.cs


 			if (openFileInfo.DisplayBinding != null) {
 				binding = viewBinding = openFileInfo.DisplayBinding;
 			} else {
-				var bindings = DisplayBindingService.GetDisplayBindings (fileName, null, project).ToList ();
+				var bindings = DisplayBindingService.GetDisplayBindings (fileName, null, owner as Project).ToList ();


I would add an overload to DisplayBindingService.GetDisplayBindings:

internal static IEnumerable<IDisplayBinding> GetDisplayBindings (FilePath filePath, string mimeType, SolutionItem owner) { //FIXME: this cannot be yet implemented without breaking IDisplayBinding.CanHandle API. // it can be fixed when default interface methods are added to the C# language. // for now, just forward to the Project version. return GetDisplayBindings (filePath, mimeType, owner as Project); }

That way there's a single place to fix it, when it's eventually possible to do so.

mhutch · 2017-08-15T22:45:41Z

main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui/Workbench.cs

 						await fw.Invoke (fileName);
 					} else {
 						var extBinding = (IExternalDisplayBinding)binding;
-						var app = extBinding.GetApplication (fileName, null, project);
+						var app = extBinding.GetApplication (fileName, null, owner as Project);


Same as for IDisplayBinding.

mhutch · 2017-08-21T21:32:09Z

build

mhutch · 2017-08-21T21:45:04Z

main/src/addins/MonoDevelop.ConnectedServices/Gui.ServicesTab/ConnectedServicesWidget.cs

-		public void ShowGallery(IConnectedService[] services, Project project)
+		public void ShowGallery (IConnectedService [] services, Project project)
+		{
+			ShowGallery (services, project as SolutionItem);


Use a hard cast here, i.e. (SolutionItem)project

The "hard" cast is a little clearer in intent. Generally, you should use a soft ("as") cast when you want to get null if the cast fails. In this case the cast cannot fail, as Project is derived from SolutionItem.

Yeah, no cast is required here.

Ignore my comment.

mhutch · 2017-08-21T21:46:26Z

main/src/addins/MonoDevelop.Refactoring/MonoDevelop.Refactoring/AnalyzeWholeSolutionHandler.cs

@@ -212,6 +212,12 @@ public EmptyDocumentContext (Project project)
 				}


This does not need to override both Project and Owner, as they are chained. Overriding Owner is enough.

mhutch · 2017-08-21T21:47:31Z

main/src/addins/MonoDevelop.SourceEditor2/MonoDevelop.SourceEditor/SourceEditorView.cs

@@ -2394,7 +2394,7 @@ void CorrectIndenting ()
 			var formatter = CodeFormatterService.GetFormatter (Document.MimeType);
 			if (formatter == null || !formatter.SupportsCorrectingIndent)
 				return;
-			var policies = Project != null ? Project.Policies : null;
+			var policies = Owner != null ? Owner.Policies : null;


FWIW this can be simplified using C# 6 syntax to

var policies = Owner?.Null;

mhutch · 2017-08-21T21:48:16Z

main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Desktop/RecentOpen.cs

+
+		public void AddFile (string fileName, SolutionItem owner)
+		{
+			var projectName = owner != null ? owner.Name : null;


Same here, this can be owner?.Name

mhutch · 2017-08-21T21:51:21Z

main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.GettingStarted/GettingStarted.cs

@@ -40,7 +40,12 @@ public static GettingStartedProvider GetGettingStartedProvider (this Project pro

 		public static GettingStartedNode GetGettingStartedNode (this Project project)
 		{
-			return project.GetService<GettingStartedProjectExtension> ()?.ProjectPadNode;
+			return GetGettingStartedNode (project as SolutionItem);


Hard cast here too.

mhutch · 2017-08-21T21:53:05Z

main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui/BaseViewContent.cs

@@ -40,6 +40,7 @@ public abstract class BaseViewContent : IDisposable
 	{
 		IWorkbenchWindow workbenchWindow;
 		Project project;


Remove this variable as it's no longer used.

mhutch · 2017-08-21T21:54:01Z

main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui/BaseViewContent.cs

 			}
 			set {
-				OnSetProject (value);
+				OnSetOwner (project);


This is not correct, the incoming value is value not project. Also, chaining would be cleaner than duplicating, i.e. Owner = value.

mhutch · 2017-08-21T21:55:01Z

main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui/DisplayBindingService.cs

@@ -115,7 +123,7 @@ public static IEnumerable<FileViewer> GetFileViewers (FilePath filePath, Project
 					yield return new FileViewer (vb);
 				} else {
 					var eb = (IExternalDisplayBinding) b;
-					var app = eb.GetApplication (filePath, mimeType, ownerProject);
+					var app = eb.GetApplication (filePath, mimeType, ownerProject as SolutionItem);


hard cast here too

mhutch · 2017-08-21T21:56:40Z

main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui/Document.cs

@@ -219,7 +219,7 @@ public object GetDocumentObject ()
 		Solution adhocSolution;

 		public override Project Project {
-			get { return (Window != null ? Window.ViewContent.Project : null) ?? adhocProject; }
+			get { return (Window != null ? Window.ViewContent.Owner as Project : null) ?? adhocProject; }


This should chain to Owner instead of duplicating it

mhutch · 2017-08-21T21:58:03Z

main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui/Document.cs

 		}

 		void ListenToProjectLoad (Project project)
 		{
+			ListenToProjectLoad (project as SolutionItem);


Hard cast here too

mhutch · 2017-08-21T22:01:04Z

@slluis - do you think it would make sense to use WorkspaceObject instead of SolutionItem for the type of Owner?

slluis · 2017-08-22T08:58:04Z

main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui/IDisplayBinding.cs

@@ -60,7 +60,7 @@ public interface IViewDisplayBinding : IDisplayBinding
 	///<summary>A display binding that opens an external application.</summary>
 	public interface IExternalDisplayBinding : IDisplayBinding
 	{
-		DesktopApplication GetApplication (FilePath fileName, string mimeType, Project ownerProject);
+		DesktopApplication GetApplication (FilePath fileName, string mimeType, SolutionItem owner);


This is an API break

slluis · 2017-08-22T09:11:23Z

@mhutch I think SolutionItem is ok.

mhutch · 2017-08-22T14:23:40Z

@slluis I was just wondering about things like items in solution folders. It would be painful to have to change the type of "Owner" later.

slluis · 2017-08-23T07:19:03Z

@mhutch there isn't much functionality we can use at this abstraction level, it could as well be an Object. In any case solution folder items is a real use case, so I'm ok with using WorkspaceObject.

mhutch · 2017-08-23T21:00:57Z

@gitexperience could you change SolutionItem to WorkspaceObject per above comment?

There may be some things that will not work because they access members that are not present on WorkspaceObject, but those can conditionally cast to the derived types that do have this functionality.

var policies = Owner?.Policies;

could become

var policies = (Owner as IPolicyProvider)?.Policies;

and

if (window.ViewContent.Owner != null)
    window.ViewContent.Owner.Modified += HandleProjectModified;

could become

if (window.ViewContent.Owner is SolutionFolderItem solutionItem)
    solutionItem.Modified += HandleProjectModified;
else if (window.ViewContent.Owner is WorkspaceItem workspaceItem)
    workspaceItem.Modified += HandleWorkspaceItemModified;

mhutch · 2017-08-23T21:01:31Z

@gitexperience also, please rebase onto master

mhutch · 2017-08-22T20:19:20Z

main/external/fsharpbinding/MonoDevelop.FSharpBinding/FSharpInteractivePad.fs

@@ -81,6 +81,7 @@ type FsiDocumentContext() =
    override x.ReparseDocument() = ()
    override x.GetOptionSet() = TypeSystemService.Workspace.Options
    override x.Project = project :> Project


This line is redundant, as you're setting Owner too

mhutch · 2017-08-23T21:03:29Z

main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Editor/Projection/ProjectedDocumentContext.cs

@@ -135,7 +136,13 @@ public override Microsoft.CodeAnalysis.Options.OptionSet GetOptionSet ()

 		public override MonoDevelop.Projects.Project Project {
 			get {
-				return originalContext.Project;
+				return originalContext.Owner as Project;


For consistency/clarity of intent, this should chain to Owner rather than accessing originalContext directly.

mhutch · 2017-09-05T03:22:40Z

Can you please rebase this onto master? The changes tab shows a lot of changes from master that appear to have been somehow cherry-picked.

gitexperience · 2017-09-12T20:43:19Z

@mhutch, rebasing done!
Can you please review the changes ?

mhutch

Looks good! Just one little issue remaining.

mhutch · 2017-09-14T17:07:31Z

main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Editor/TextEditorViewContent.cs

@@ -155,7 +156,7 @@ void UpdateStyleParent (MonoDevelop.Projects.Project styleParent, string mimeTyp
 			var mimeTypes = DesktopService.GetMimeTypeInheritanceChain (mimeType);

 			if (styleParent != null)
-				policyContainer = styleParent.Policies;
+				policyContainer = (styleParent as IPolicyProvider).Policies;


This will throw a NRE if the styleParent does not implement IPolicyProvider.

I think this entire if/else could be simplified to

policyContainer = (styleParent as IPolicyProvider) ?.Policies ?? policyContainer = MonoDevelop.Projects.Policies.PolicyService.DefaultPolicies

gitexperience · 2017-09-15T21:14:42Z

@mhutch , Done!

gitexperience · 2017-09-28T07:27:35Z

@slluis @mhutch do we need more changes in this PR ?
I just rebased it again because of some merge conflicts.

mhutch · 2017-09-28T21:24:25Z

It looks good to me but I'd like @slluis to take a look too

slluis · 2017-10-02T07:36:02Z

main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Editor/TextEditorViewContent.cs

@@ -257,7 +257,14 @@ public override void DiscardChanges ()
 		protected override void OnSetProject (MonoDevelop.Projects.Project project)


It is not necessary to override OnSetProject if OnSetOwner is overriden.

slluis · 2017-10-02T07:42:59Z

main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui/DefaultWorkbench.cs

-			if (window.ViewContent.Project != null) {
-				documentUrl = "file://" + window.ViewContent.Project.FileName;
+			if (window.ViewContent.Owner != null) {
+				documentUrl = "file://" + window.ViewContent.Owner.BaseDirectory.FileName;


This is not correct, this will return the directory name, not the file name

@slluis, window.ViewContent.Project.FileName is working fine here so I left it as it is. Can you please review?

slluis · 2017-10-02T07:51:16Z

main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui/Document.cs

 			InitializeExtensionChain ();
-			ListenToProjectLoad (project);
+			ListenToProjectLoad (owner);
 		}

 		void ListenToProjectLoad (Project project)


This method is not necessary.

gitexperience · 2017-12-29T19:01:56Z

@slluis do we need more changes in this PR ?

msftclas added the cla-required label Aug 5, 2017

mhutch suggested changes Aug 7, 2017

View reviewed changes

slluis suggested changes Aug 8, 2017

View reviewed changes

gitexperience force-pushed the master branch from c6e92c9 to 6b36c96 Compare August 8, 2017 15:43

gitexperience changed the title ~~[Addin] (Test PR) To allow CBinding to use "Project" property~~ [Addin] To allow CBinding to use "Project" property Aug 8, 2017

gitexperience commented Aug 13, 2017

View reviewed changes

mhutch suggested changes Aug 14, 2017

View reviewed changes

mhutch suggested changes Aug 15, 2017

View reviewed changes

mhutch suggested changes Aug 21, 2017

View reviewed changes

msftclas added cla-signed and removed cla-required labels Aug 21, 2017

slluis reviewed Aug 22, 2017

View reviewed changes

mhutch suggested changes Aug 23, 2017

View reviewed changes

gitexperience force-pushed the master branch from 21311f4 to 1fdb5f7 Compare August 30, 2017 18:58

gitexperience force-pushed the master branch 2 times, most recently from f2f76cd to 0dbd452 Compare September 5, 2017 07:01

mhutch suggested changes Sep 14, 2017

View reviewed changes

gitexperience force-pushed the master branch from 71dd503 to c3a2d64 Compare September 15, 2017 21:06

gitexperience dismissed mhutch’s stale review via ce82be8 September 28, 2017 07:23

gitexperience force-pushed the master branch from c3a2d64 to ce82be8 Compare September 28, 2017 07:23

slluis reviewed Oct 2, 2017

View reviewed changes

slluis suggested changes Oct 2, 2017

View reviewed changes

ghost removed the cla-signed label Nov 8, 2017

ghost deleted a comment from msftclas Nov 8, 2017

gitexperience force-pushed the master branch 2 times, most recently from 345afe7 to ce82be8 Compare November 22, 2017 13:36

gitexperience added 11 commits November 28, 2017 00:10

Test Commit- to allow CBinding to use Project property

76d400c

changes for consistency and backwards compatibility

0840c8f

Allows chaining of Project to Owner in DocumentContext

a8ebb00

Overload of an OpenDocument for SolutionItem

4ebfe92

Chaining Project to Owner in FileOpenInformation class

a8d1010

Some Fixes in chaining

6f313b8

Minor Fixes

5f3f5f2

Overload of an OpenDocument for SolutionItem

8760efa

Chains Project to WorkspaceObject

89f1ae8

Small Fix

108ebc8

Added check to prevent NRE in TextEditorViewContent.cs

2e503dd

gitexperience force-pushed the master branch from 6f070b2 to 2e503dd Compare November 27, 2017 18:45

Minor Fixes

16750af

slluis added this to the 15.6 milestone Dec 5, 2017

gitexperience mentioned this pull request Jan 5, 2018

Issue #3437 #3440

Closed

slluis removed this from the 15.6 milestone Mar 7, 2018

Base automatically changed from master to main March 9, 2021 14:17

akoeplinger changed the base branch from main to master March 15, 2021 17:02

Base automatically changed from master to main March 15, 2021 17:03

		@@ -88,6 +88,12 @@ protected override void OnSetProject (MonoDevelop.Projects.Project project)
		content.Project = project;

		@@ -115,6 +115,12 @@ protected override void OnSetProject (Projects.Project project)
		content.Project = project;

		@@ -142,6 +143,20 @@ internal protected virtual void OnDeselected ()
		protected virtual void OnSetProject (Project project)

		@@ -55,6 +55,7 @@ public sealed class ParseOptions
		public ITextSource Content { get; set; }

		public MonoDevelop.Projects.Project Project { get; set; }

		@@ -9,6 +9,7 @@ type TestDocument(name, parsedDocument, editor: TextEditor) =

		override x.Name = name
		override x.Project = null

		@@ -212,6 +212,12 @@ public EmptyDocumentContext (Project project)
		}

		@@ -257,7 +257,14 @@ public override void DiscardChanges ()
		protected override void OnSetProject (MonoDevelop.Projects.Project project)

[Addin] To allow CBinding to use "Project" property #2870

Are you sure you want to change the base?

[Addin] To allow CBinding to use "Project" property #2870

Conversation

gitexperience commented Aug 5, 2017

monojenkins commented Aug 5, 2017

mhutch left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

slluis commented Aug 8, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mhutch left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mhutch commented Aug 21, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mhutch commented Aug 21, 2017

Choose a reason for hiding this comment

slluis commented Aug 22, 2017

mhutch commented Aug 22, 2017

slluis commented Aug 23, 2017

mhutch commented Aug 23, 2017

mhutch commented Aug 23, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mhutch commented Sep 5, 2017

gitexperience commented Sep 12, 2017

mhutch left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gitexperience commented Sep 15, 2017

gitexperience commented Sep 28, 2017

mhutch commented Sep 28, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gitexperience commented Dec 29, 2017