-
Notifications
You must be signed in to change notification settings - Fork 1k
Fsharp status bar tooltips #3084
base: main
Are you sure you want to change the base?
Conversation
49090b1
to
ec93c4f
Compare
This might be better in the lower left of the bottom bar? Or might be worth revisiting after #3100 gets merged |
But also, the new UI doesn't have accessibility hints. |
Yeah, I think so too. No idea how to do that though :) |
ec93c4f
to
83cafc1
Compare
a138a4b
to
e961060
Compare
e961060
to
16e35fb
Compare
That looks really cool, but would it be better if it was a bar in the bottom of the text editor (if possible). I'm thinking about the eye travel distance. It isn't horrible on a horizontal monitor, but it could be a fair bit on a vertical monitor? |
That space at the bottom is currently doing nothing right now, seems a shame to waste it. |
true, maybe cycle cool random F# tips ;) |
There was a conscious decision of removing the status bar when XS was redesigned a few years ago. I think it would make more sense to show the status in a bar in the text editor, but I'd like to have the opinion from @vancura @hbons @migueldeicaza. |
Window status area is indeedly not the right place to show this information. We need something better. Let me think. |
If I understand this well, the information currently shown in the toolbar status area is just a quick help, right? If that's right, I'd rather show it on a keypress in a bubble on top of the TextEditor. Something that JetBrains use to inspect declaration of the method. |
@vancura - the idea is that it isn't distracting and is automatic. Every other editor/IDE has this. It's also currently an option that is disabled by default - you have to enable it. |
By the way, I also think it's way too detached if it's in toolbar or footer. It should close to where you're looking at. |
I'd like to have the same feature but in a bar beneath the editor if it's not possible to use the footer area. I've been using this feature for years in other editors and I find working in VS for Mac jarring for this reason. I don't want to use the mouse to see the tooltip. There are probably accessibility considerations in play here also.
No, not quite the same thing, that's parameter help. Certainly possible to display a tooltip with a keybind, but I wouldn't want it to be the only way to get this information. |
I got it. Well, the problem is we don't have any permanent panel we could display it on, like VSCode's footer. Toolbar status area is a wrong place to use for such a feature, but I don't think we should re-introduce footer just because of this. @maryanne-exe @hbons Thoughts? |
Sorry to rain on your parade. We just need to come up with some better place. |
Agree that status bar isn't the right place for these hints, let's leave it for IDE related updates.
I think it's reasonable to have a hotkey to display the hint.
|
cec01bc
to
7d6729b
Compare
@nosami: Do you think a keyboard shortcut to invoke the feature would be too much? |
@vancura - It's not difficult at all. I feel like it that would be only be half as useful though. I would still want a way to always see the current type information without having to press some shortcut key constantly while evaluating some unfamiliar code. The popup tooltip also obscures the view of the code which makes things a little awkward when trying to determine how a block of code works. F#'s strong type inferencing means that type information isn't visible in the actual source code, and this type of tooltip becomes far more valuable than it would be for a C# developer. |
It would be really a nice feature if we find a good spot to draw it on. Let's summarize the requirements:
Am I right? |
I am sorry that we need to postpone your branch, but let's first make sure this looks and behaves really nice, it could be a killer feature, and not only for F#. |
@vancura - yes, ideally. I'm not opposed to having a shortcut provided that there is an option to have it always visible as well. Not too sure about it being near the caret though as that moves constantly... and anywhere near the caret would obscure other code. I'd prefer somewhere static, either in the IDE frame, or per editor frame. |
Please see the xamarin/design issue above. Also, I am marking this PR as not-to-be-merged yet. |
This should be added as well to our online help pad that we have discussed. |
The shortcut is undiscoverable, so I rather not rely on that. For F# we need this kind of help. |
7d6729b
to
497d901
Compare
f425c48
to
8ce3a9b
Compare
8ce3a9b
to
9ff58b6
Compare
9ff58b6
to
057152c
Compare
057152c
to
4d165b2
Compare
732c796
to
c0f859b
Compare
c0f859b
to
4d8e32a
Compare
4d8e32a
to
d9b2c4a
Compare
Useful if you don't use the mouse.