-
Notifications
You must be signed in to change notification settings - Fork 1k
[gtk2] Update templates to Gtk# 2.12 #5183
base: main
Are you sure you want to change the base?
Conversation
Real talk: Gtk# 2.6 shipped in 2005, and we don't support 2.4. This should fix Gtk#2 projects going screwy if you have Gtk#3 installed
<Reference type="Package" SpecificVersion="true" refto="glib-sharp, Version=2.12.0.0, Culture=neutral, PublicKeyToken=35e10195dab3c99f" /> | ||
<Reference type="Package" SpecificVersion="true" refto="glade-sharp, Version=2.12.0.0, Culture=neutral, PublicKeyToken=35e10195dab3c99f" /> | ||
<Reference type="Package" SpecificVersion="true" refto="pango-sharp, Version=2.12.0.0, Culture=neutral, PublicKeyToken=35e10195dab3c99f" /> | ||
<Reference type="Package" SpecificVersion="true" refto="atk-sharp, Version=2.12.0.0, Culture=neutral, PublicKeyToken=35e10195dab3c99f" /> | ||
</References> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other templates specify Gtk2. If you "hardcode" this to gtk2 we should probably rename the template to something like FSharpGtk2Project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am okay with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a rename, which seems to have worked.
This brings the template in line with other Gtk2 templates for C#/VB
It seems even with the changes in this PR, it doesn't force 2.12. The version bumping is unbeatable.
Looking at the msbuild log, it seems MD is always resolving from GAC, not from pkg-config, and ignoring the exact version requirement. |
... because msbuild doesn't support pkg-config, but xbuild does. msbuild on the csproj fails, xbuild on the csproj is fine. |
@radical this seems bigger than it first appeared, you're the domain expert. Summary: xbuild resolves from PkgConfig (a custom search path location in Mono Microsoft.Build.Tasks), and returns the specified assembly version. msbuild doesn't support PkgConfig resolver, and also ignores specific version requests in favour of $LATEST found in GAC. How to fix? |
Is this just for these specific templates? You could try |
@radical it looks like adding a I guess we need to add that to the IDE's pkg-config reference handling code? |
Real talk: Gtk# 2.6 shipped in 2005, and we don't support 2.4.
This should fix Gtk#2 projects going screwy if you have Gtk#3 installed