This repository was archived by the owner on Oct 4, 2021. It is now read-only.
[Mac] Use NSAppleScript instead of Carbon to spawn the terminal process #6215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Therzok
reviewed
Oct 5, 2018
| : base (GetFullMessage (error, returnValue)) | ||
| static class NSAppleScriptError | ||
| { | ||
| public const string Number = "NSAppleScriptErrorNumber"; |
There was a problem hiding this comment.
|
@mhutch Ah, of course. |
iainx
commented
Oct 5, 2018
| var dict = new Dictionary<string, string> (); | ||
| DecodeDescriptor (result, dict); | ||
|
|
||
| if (result == null) { |
There was a problem hiding this comment.
I should probably check null before I try to decode...
iainx
force-pushed
the
use-nsapplescript
branch
from
0bd4940 to
d0166a5
Compare
|
@iainx Can you explain what does this fix? Can we have a work item for it? |
|
It doesn't fix anything really, it just removes some old complicated Carbon code. |
|
Ok, I'm not qualified to review this, somebody else will have to. |
|
I've made a user story for removing carbon code, and added this as a task under it https://devdiv.visualstudio.com/DevDiv/_workitems/edit/703355 |
|
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/703346 is the parent user story |
|
We can break API in release-8.0. We should rebase it on top of that. |
iainx
force-pushed
the
use-nsapplescript
branch
from
d0166a5 to
779be79
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses Cocoa's NSAppleScript class to do all the heavy lifting of compiling and executing the AppleScript code.
Fixes VSTS #703355.