[Version Control] Avoid creating .git if it already exists

[jsuarezruiz]

When creating a new project into a folder which already has already been setup as a git repo, avoid create the .git folder.

Fixes VSTS #660470

[mrward]

Just wondering if we could/should make this logic available to the New Project dialog so it could disable the Git options before it reaches this code.

[mrward]

Currently the New Project dialog enables/disables the git checkbox here -

monodevelop/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Projects/NewProjectController.cs

Line 287 in 40d52a9

finalConfigurationPage.IsUseGitEnabled = IsNewSolution && (versionControlHandler != null);

Either the logic could be moved into the New Project dialog or the IVersionControlProjectTemplateHandler could be extended with a new method which the New Project dialog could call to see if git can be enabled.

I guess one problem here is that the logic is dependent on where the solution is being created. So after the location is changed the new project dialog would need to check to see if the git checkbox should be enabled/disabled. Currently this check is just done the one time.

[sevoku]

I like this idea, lets's add a IVersionControlProjectTemplateHandler.CanCreateRepository (FilePath atPath). FinalProjectConfigurationPage could have an additional ParentFolderChanged event and the NewProjectController would subscribe to that and set IsUseGitEnabled based on the result of CanCreateRepository.

[jsuarezruiz]

Matt, I liked your idea. Thanks guys for the feedback!. I have made changes to disable the Git option if a .git folder already exists (in the selected path).
However, I have some doubts. Should we show a warning icon with a popup and information in this case? Thus, in case of doubt the user knows why it is disabled. Another one, should we check for a .gitignore file and if exists disable the option to create the gitignore file?

[sevoku]

I'm not sure about the warning, I think VS on Windows doesn't tell anything or does it?

About Gitignore: I'd say let's keep it as is. Because a gitignore can live inside a subfolder. Of course we could check if it exists or not, but this would require additional interface changes, which is already not very clean (the API pretends to be generic for all VCS systems, but the UI refers to git only, and Gitignore is git specific, hence we would really need to rewrite this whole thing).
I'd propose to do the check in ProjectTemplateHandler.cs where it actually creates that file: if it exists, just skip it, if not create it in the NEW PROJECT/SOLUTION folder (not repo root).

[mrward]

Can we add tests for this new logic?

There are some tests for the IsGitIgnoreEnabled flag in the NewProjectDialogTests.

Also should the IsUseGitEnabled check be removed here? That is used

monodevelop/main/tests/Ide.Tests/MonoDevelop.Ide.Projects/NewProjectDialogTests.cs

Line 273 in f9839cd

Assert.IsFalse (controller.FinalConfiguration.IsGitIgnoreEnabled);

[jsuarezruiz]

The behavior with .gitignore with this changes:

• .gitginore exists in project folder (not parent, given the selected target folder already exists) > disable and uncheck checkbox.
• .gitignore exists in a parent folder > enable and uncheck checkbox.
• .gitignore does not exist (neither target nor parent folder) > enable and check the checkbox.

I have reviewed the tests too:

[mkrueger]

Just the EventArgs thing :).

[jsuarezruiz]

Hey @mkrueger, thanks for the feedback but, what do you mean by the EventArgs?

[sevoku]

@jsuarezruiz I think @mkrueger meant to use EventArgs.Empty instead of creating a new instance

[jsuarezruiz]

Ah, ok!. Changed. Thanks guys.