This repository was archived by the owner on Oct 4, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1k
Fixes VSTS Bug 946429: Document model content callback API edge cases #8772
Open
mkrueger
wants to merge
1
commit into
main
Choose a base branch
from
master-vsts946429
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Therzok
reviewed
Sep 19, 2019
Therzok
approved these changes
Sep 19, 2019
sevoku
approved these changes
Sep 23, 2019
@slluis ping |
Therzok
reviewed
Sep 27, 2019
Therzok
reviewed
Sep 27, 2019
Therzok
suggested changes
Sep 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise we'll effectively leak token registrations. |
Therzok
reviewed
Oct 10, 2019
@mkrueger ping! |
501b20c
to
950797c
Compare
@sevoku pong! |
Therzok
approved these changes
Oct 25, 2019
sevoku
approved these changes
Nov 5, 2019
@monojenkins rebase |
950797c
to
6953d92
Compare
Therzok
reviewed
Nov 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have some tests?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/946429