Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use None/Include to ensure items are included in generated nupkg files. #177

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

abbottdev
Copy link

Hopefully this is a straightforward one - I think the latest dependency fixes regressed the T4.BuildTools packages as the targets/props files weren't included in the nupkg.

Have run dotnet build locally and can confirm these changes ensure the props/targets are included.

This should address #176

Thanks!

@mhutch
Copy link
Member

mhutch commented Jan 24, 2024

Thanks! I was certain these items were present in the build, so I did some digging and this is super weird. It's an oddity in the way NuGet packs items when multitargeting.

The issue appears to be that NuGet collects the None items from the outer build. However, the SDK only evaluates default item wildcards in the inner build, presumably for performance reasons.

Switching these from Update to Include means that the inner build will have duplicate copies of these items, which isn't great, but I don't see any cleaner way to work around the NuGet issue.

@mhutch mhutch merged commit b0ef142 into mono:main Jan 25, 2024
4 of 5 checks passed
@mhutch
Copy link
Member

mhutch commented Jan 25, 2024

The failing test appears to be an existing race that is hopefully fixed by #178

I'll land a couple other fixes then publish a new preview to nuget.org.

@abbottdev abbottdev deleted the feature/fix-prop-includes branch January 26, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants