Added support for chapters by implementing the frames CHAP and CTOC #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@JanRomero Thanks! I'm good with the PR. The only ask I have is if you could add unit tests for this? |
|
@JanRomero @dnfadmin @decriptor Hi guys, will this be merged? |
|
@decriptor when are you going to push it to nuget? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. This is sort of rudimentary. Ideally I would like to expose the chapters directly from the File’s Tag property and have TagLib handle the internals like generating ids and enforcing uniqueness, but it’s been working fine for me going through
(TagLib.Id3v2.Tag)File.GetTag(TagLib.TagTypes.Id3v2)and setting the frames up manually.