Skip to content
This repository has been archived by the owner on Sep 4, 2024. It is now read-only.

Use XmlSerializer instead of insecure BinaryFormatter in TransferDataSource #1114

Merged
merged 6 commits into from
Feb 21, 2023
Merged

Use XmlSerializer instead of insecure BinaryFormatter in TransferDataSource #1114

merged 6 commits into from
Feb 21, 2023

Conversation

sevoku
Copy link
Member

@sevoku sevoku commented Feb 16, 2023

No description provided.

@sevoku sevoku force-pushed the dev/sevoku/remove-binaryformatter branch from e3d9f42 to 327e01e Compare February 16, 2023 15:48
@sevoku sevoku force-pushed the dev/sevoku/remove-binaryformatter branch from 45e47b6 to c997892 Compare February 17, 2023 11:35
@sevoku sevoku marked this pull request as ready for review February 17, 2023 12:59
@BretJohnson
Explicitly set Xwt TargetFramework
c2c3eaa 
Explicitly set the TargetFramework in Xwt.csproj
to netstandard2.0, so that it builds properly on
Windows (where it otherwise would default to
.NET Framework 4.6.1).
@BretJohnson
Update to 4.7.2 in Directory props as well
0ed0b92
@Therzok
Copy link
Contributor

Therzok commented Feb 19, 2023

Can we instead download gtk# from the github releases? https://github.com/mono/gtk-sharp/releases

@sevoku
Copy link
Member Author

sevoku commented Feb 20, 2023

Can we instead download gtk# from the github releases? https://github.com/mono/gtk-sharp/releases

Oh nice, I didn't know this existed! Will try in #1115

@Therzok
Copy link
Contributor

Therzok commented Feb 20, 2023

Oh nice, I didn't know this existed! Will try in #1115

Nor did I. I think it's behind a few versions, but it's newer than what you're installing in appveyor.

@BretJohnson
Use XML serialization instead of JSON serialization
6ed2ea5 
XML serialization works better than JSON for Android designer
data - it's formatted better and is more mature, with more
options supported.
@BretJohnson
Revert adding Json package ref
aca3cf7
@BretJohnson BretJohnson changed the title Use JsonSerializer instead of insecure BinaryFormatter in TransferDataSource Use XmlSerializer instead of insecure BinaryFormatter in TransferDataSource Feb 21, 2023
@BretJohnson BretJohnson self-requested a review February 21, 2023 06:47
@BretJohnson
Copy link
Collaborator

I updated this to use XmlSerializer instead of JsonSerializer, as that works better for Android designer drag & drop / clipboard (the formatting is better and in general the XML serializer is more mature, with more options). I also switched to .NET 4.7.2, from 4.6.1, on Windows. With those changes, I tested and (with other required changes on the Android designer side) everything works OK. So this is good to merge from my perspective.

mrward
mrward reviewed Feb 21, 2023
View reviewed changes
Xwt/Xwt.csproj
@@ -1,5 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: SDK style projects do not usually have this xml header.

@sevoku sevoku merged commit bc8ae85 into main Feb 21, 2023
@sevoku sevoku deleted the dev/sevoku/remove-binaryformatter branch February 21, 2023 12:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrward mrward mrward approved these changes

@BretJohnson BretJohnson BretJohnson approved these changes

@Therzok Therzok Therzok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sevoku @Therzok @BretJohnson @mrward