Skip to content
This repository has been archived by the owner on Sep 4, 2024. It is now read-only.

Simplify implementation for ImageTagSet equality #1116

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Simplify implementation for ImageTagSet equality #1116

wants to merge 11 commits into from

Commits on Feb 20, 2023

  1. Simplify implementation for ImageTagSet equality

    @Therzok
    Therzok committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    3550ded View commit details
    Browse the repository at this point in the history

  2. Reuse the same tag separator array 

    We're targeting netstandard2.0 and don't have ReadOnlySpan or any of the new APIs that avoid allocating
    @Therzok
    Therzok committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    25cb1aa View commit details
    Browse the repository at this point in the history

  3. Add a lookup table for most common tags used in images

    @Therzok
    Therzok committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    30ee113 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. Remove unused tags string and improvements to caching 

    We cache the ImageTagSet directly now. That should allow us to create fewer of these instances overall.
For the app I'm testing on, we cover 97% of the image tags combinations
In practice, cache hits will be better overall.

The other improvement is to not have to sort/create imagetagsets every time, instead opting to use more specialized APIs.
    @Therzok
    Therzok committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    1557d48 View commit details
    Browse the repository at this point in the history

  2. Forgot to initialize

    @Therzok
    Therzok committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    455d72b View commit details
    Browse the repository at this point in the history

  3. Correct formatting of tags string

    @Therzok
    Therzok committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    3dd2e28 View commit details
    Browse the repository at this point in the history

  4. Avoid allocating substrings

    @Therzok
    Therzok committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    cb9c628 View commit details
    Browse the repository at this point in the history

  5. Reuse a cached array for the manifest resource names

    @Therzok
    Therzok committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    7511a91 View commit details
    Browse the repository at this point in the history

  6. More caching in enumerating alternative files

    @Therzok
    Therzok committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    681e4cd View commit details
    Browse the repository at this point in the history

  7. Use specialized APIs to get the handles

    @Therzok
    Therzok committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    be8d81a View commit details
    Browse the repository at this point in the history

  8. This shoudl be static

    @Therzok
    Therzok committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    b4ceca4 View commit details
    Browse the repository at this point in the history