Skip to content
This repository has been archived by the owner on Sep 4, 2024. It is now read-only.

Add ListViewColumn and CellView expansion #662

Merged
merged 12 commits into from
Mar 31, 2017

Conversation

sevoku
Copy link
Member

@sevoku sevoku commented Mar 28, 2017

This patch adds expansion support for ListView/TreeView columns and cells.
New API:

  • ListViewColumn.Expands: the column expands to fill all available space inside the view.
  • CellView.Expands: the cell view expands horizontally to fill all available space inside its column. Due to toolkit limitations CellView expanding can be only set upon creation, CellView.Expands is read only.

TODO: Wpf column expansion

@slluis
Copy link
Member

slluis commented Mar 28, 2017

I feel it would be more consistent if the expand argument is specified when adding the cell to the cellview collection. CellViewCollection could have overloads for Add and Insert that take an expands argument (which could still be internally stored in CelllView).

sevoku added 2 commits March 28, 2017 15:02
Allow to specify the Expands parameter when
adding CellViews to Columns.
@sevoku
Copy link
Member Author

sevoku commented Mar 28, 2017

Yeah, that's a good idea! Done: f745dc8
The CellView constructor parameter is still useful I think, or should we remove it now?

@slluis
Copy link
Member

slluis commented Mar 28, 2017

I would remove it now.

Removes the constructor introduced in 3741844,
the new CellViewCollection.Add overload can be used instead.
@sevoku
Copy link
Member Author

sevoku commented Mar 28, 2017

ok, done

@garuma garuma merged commit 26d2efa into mono:master Mar 31, 2017
@garuma
Copy link
Contributor

garuma commented Mar 31, 2017

Merged since we need this for one of our feature work and it was approved

sevoku added a commit that referenced this pull request Jan 3, 2018
Remove deprecated column sizing code, since column sizing
is now handled by the base backend code (changed in #662)

(fixes #765)
Therzok pushed a commit that referenced this pull request Jan 3, 2018
Remove deprecated column sizing code, since column sizing
is now handled by the base backend code (changed in #662)

(fixes #765)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants