Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge scripts/process_divisions.py with climate_indices/__main__.py for a single indices processing entry point #284

Closed
2 tasks done
monocongo opened this issue Mar 12, 2019 · 1 comment
Closed
2 tasks done

Merge scripts/process_divisions.py with climate_indices/__main__.py for a single indices processing entry point #284

monocongo opened this issue Mar 12, 2019 · 1 comment

Comments

@monocongo
Copy link
Owner

monocongo commented Mar 12, 2019 •
edited
Loading

In order to have a single entry point script for processing indices, we should merge scripts/process_divisions.py with climate_indices/__main__.py. This will involve:

  • detecting whether or not we have gridded or division inputs
  • modifying commonly used functions to be compatible with both gridded and division datasets

This will provide a single entry point script, allowing for the elimination of the scripts directory and the two separate (but similar) indices processing scripts therein. Completion of this issue will facilitate the completion of issue #280.
monocongo added a commit that referenced this issue Mar 12, 2019
@monocongo
added some arguments validation for US climate divisions (incomplete)…
ca3f4d5 
…, including an enumeration class (grid/divisions)

#284
monocongo added a commit that referenced this issue Mar 12, 2019
@monocongo
additional arguments validation for the Palmers related arguments
c3a4249 
#284
monocongo added a commit that referenced this issue Mar 12, 2019
@monocongo
chunk sizing for grid/divs input types
df4f25a 
#284
monocongo added a commit that referenced this issue Mar 12, 2019
@monocongo
separate functions for dropping data into shared memory arrays for gr…
7880fc2 
…id/divs input types

#284
monocongo added a commit that referenced this issue Mar 12, 2019
@monocongo
fixes for lint inspection issues
5d309ab 
#284
monocongo added a commit that referenced this issue Mar 12, 2019
@monocongo
fixed dimension checking bug
5deac24 
#284
monocongo added a commit that referenced this issue Mar 12, 2019
@monocongo
fixed some issues around handling the lat variable and computing PET …
4c791ba 
…for divisions

#284
monocongo added a commit that referenced this issue Mar 12, 2019
@monocongo
changed the entry point name to process_climate_indices to be more ge…
0ee685c 
…neric

#284
monocongo added a commit that referenced this issue Mar 12, 2019
@monocongo
additional comments in main script section
decf375 
#284
monocongo added a commit that referenced this issue Mar 12, 2019
@monocongo
added periodicity argument for Palmers and additional supported units…
a8209f0 
… strings for temperature (Fahrenheit related)

#284
monocongo added a commit that referenced this issue Mar 12, 2019
@monocongo
updated documentation, removed the scripts directory and script files
3205863 
#284
monocongo added a commit that referenced this issue Mar 12, 2019
@monocongo
removed the scripts entry from setup.py
eece909 
#284
@monocongo
Copy link
Owner Author

Resolved by PR #285

monocongo added a commit that referenced this issue Mar 12, 2019
@monocongo
updated version to 1.0.3
81ce9ef 
#284
@monocongo monocongo mentioned this issue Mar 29, 2019
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@monocongo